Fix memory leak in main menu (News browser)

The new way is cascading delete of all parent's children, removed function had many issues including dangling parent pointer, double deletion risk, UAF

Fixed memory leak: m_pButtonNewsLink

Author: Dutchman101

Client/core/CNewsBrowser.cpp

@@ -26,6 +26,7 @@ CNewsBrowser::CNewsBrowser()
     m_pWindow = NULL;
     m_pTabPanel = NULL;
     m_pButtonOK = NULL;
+    m_pButtonNewsLink = NULL;
 }
 
 ////////////////////////////////////////////////////
@@ -199,31 +200,15 @@ void CNewsBrowser::CreateGUI()
 ////////////////////////////////////////////////////
 void CNewsBrowser::DestroyGUI()
 {
-    // Destroy
-    for (uint i = 0; i < m_TabList.size(); i++)
-    {
-        CGUITab* pTab = m_TabList[i];
-        if (pTab)
-            delete pTab;
-    }
-    m_TabList.clear();
-    for (uint i = 0; i < m_TabContentList.size(); i++)
-    {
-        CGUIWindow* pWindow = m_TabContentList[i];
-        if (pWindow)
-        {
-            CGUIElement* m_pScrollPane = pWindow->GetParent();
-            if (m_pScrollPane)
-            {
-                delete m_pScrollPane;
-            }
-            delete pWindow;
-        }
-    }
-    m_TabContentList.clear();
-    SAFE_DELETE(m_pTabPanel);
+    // Clean up the main UI elements in reverse order of creation
+    SAFE_DELETE(m_pTabPanel);  // This will destroy all tabs and their children
     SAFE_DELETE(m_pButtonOK);
+    SAFE_DELETE(m_pButtonNewsLink);
     SAFE_DELETE(m_pWindow);
+
+    // Clear the lists after the GUI objects are destroyed
+    m_TabList.clear();
+    m_TabContentList.clear();
 }
 
 ////////////////////////////////////////////////////