Synchronize changes from 1.6 branch [ci skip]

9eb15a7 Addendum #3 to db63a1: Fix offset notes (1 regressed, 1 missing)
4dd4653 Addendum #2 to db63a1: Fix comment style and add another entry
d585ea6 Addendum to db63a1d: Correct documentation (that, and commit desc, was wrong: 0x0002A733 = 0x0001F4B3)
86e63cb Avoid d3d9.dll crash @ 0x0002A733 (Top 5 most popular MTA crash) and add known incompatible d3d9.dll interface.
363e2b5 Different approach for 8e4f245 (Fix vertex buffer lock failures)
2bedbb1 Fix buffer lock failures (and the #4 most common SA crash @ 0x00354B1C)

Author: github-actions[bot]

Client/core/DXHook/CProxyDirect3DVertexBuffer.cpp

@@ -111,17 +111,23 @@ HRESULT CProxyDirect3DVertexBuffer::Lock(UINT OffsetToLock, UINT SizeToLock, voi
 
     *ppbData = NULL;
     HRESULT hr = DoLock(OffsetToLock, SizeToLock, ppbData, Flags);
+    HRESULT originalHr = hr;
+
+    if (SUCCEEDED(hr) && *ppbData == NULL)
+    {
+        hr = D3DERR_INVALIDCALL;
+    }
 
     // Report problems
-    if (FAILED(hr) || *ppbData == NULL)
+    if (FAILED(hr))
     {
         struct
         {
             const char* szText;
             uint        uiReportId;
             uint        uiLogEventId;
         } info;
-        if (hr == D3D_OK)
+        if (hr == D3DERR_INVALIDCALL && originalHr == D3D_OK)
             info = {"result NULL", 8621, 621};
         else if (hr == STATUS_ARRAY_BOUNDS_EXCEEDED)
             info = {"offset out of range", 8622, 622};
@@ -130,8 +136,8 @@ HRESULT CProxyDirect3DVertexBuffer::Lock(UINT OffsetToLock, UINT SizeToLock, voi
         else
             info = {"fail", 8620, 620};
 
-        SString strMessage("Lock VertexBuffer [%s] hr:%x Length:%x Usage:%x FVF:%x Pool:%x OffsetToLock:%x SizeToLock:%x Flags:%x", info.szText, hr, m_iMemUsed,
-                           m_dwUsage, m_dwFVF, m_pool, OffsetToLock, SizeToLock, Flags);
+        SString strMessage("Lock VertexBuffer [%s] hr:%x origHr:%x Length:%x Usage:%x FVF:%x Pool:%x OffsetToLock:%x SizeToLock:%x Flags:%x", info.szText, hr,
+                           originalHr, m_iMemUsed, m_dwUsage, m_dwFVF, m_pool, OffsetToLock, SizeToLock, Flags);
         WriteDebugEvent(strMessage);
         AddReportLog(info.uiReportId, strMessage);
         CCore::GetSingleton().LogEvent(info.uiLogEventId, "Lock VertexBuffer", "", strMessage);