Revert "Revert "CRemoteCalls: make callRemote return 0 as errno upon success (#295)""

qaisjp · qaisjp · commit 507de5fc63fe · 2019-09-02T23:36:53.000+01:00
This reverts commit 25ffe62.
diff --git a/Server/mods/deathmatch/logic/CRemoteCalls.cpp b/Server/mods/deathmatch/logic/CRemoteCalls.cpp
@@ -243,12 +243,10 @@ void CRemoteCall::DownloadFinishedCallback(const SHttpDownloadResult& result)
         if (result.bSuccess)
         {
             if (pCall->IsFetch())
-            {
                 arguments.PushString(std::string(result.pData, result.dataSize));
-                arguments.PushNumber(0);
-            }
             else
                 arguments.ReadFromJSONString(result.pData);
+            arguments.PushNumber(0);
         }
         else
         {

Original file line number	Diff line number	Diff line change
`@@ -243,12 +243,10 @@ void CRemoteCall::DownloadFinishedCallback(const SHttpDownloadResult& result)`
`243`	`243`	`if (result.bSuccess)`
`244`	`244`	`{`
`245`	`245`	`if (pCall->IsFetch())`
`246`		`- {`
`247`	`246`	`arguments.PushString(std::string(result.pData, result.dataSize));`
`248`		`- arguments.PushNumber(0);`
`249`		`- }`
`250`	`247`	`else`
`251`	`248`	`arguments.ReadFromJSONString(result.pData);`
	`249`	`+ arguments.PushNumber(0);`
`252`	`250`	`}`
`253`	`251`	`else`
`254`	`252`	`{`