Fix #1440 driveby pitch inverted sometimes

Author: Zangomangu

Client/game_sa/CPedSA.cpp

@@ -1027,6 +1027,18 @@ int CPedSA::GetCustomMoveAnim()
     return m_iCustomMoveAnim;
 }
 
+bool CPedSA::IsDoingGangDriveby()
+{
+    auto   pTaskManager = m_pPedIntelligence->GetTaskManager();
+    CTask* pTask = pTaskManager->GetTask(TASK_PRIORITY_PRIMARY);
+    if (pTask && pTask->GetTaskType() == TASK_SIMPLE_GANG_DRIVEBY)
+    {
+        return true;
+    }
+
+    return false;
+}
+
 /*
 bool CPedSA::CanPedReturnToState (  )
 {

Client/game_sa/CPedSA.h

@@ -447,6 +447,7 @@ class CPedSA : public virtual CPed, public virtual CPhysicalSA
     void         AddWeaponAudioEvent(EPedWeaponAudioEventType audioEventType);
 
     virtual int GetCustomMoveAnim();
+    bool        IsDoingGangDriveby();
 
     static void StaticSetHooks();
 };

Client/multiplayer_sa/multiplayer_shotsync.cpp

@@ -140,7 +140,13 @@ bool IsLocalPlayer(CPedSAInterface* pPedInterface)
 
 VOID WriteGunDirectionDataForPed(CPedSAInterface* pPedInterface, float* fGunDirectionX, float* fGunDirectionY, char* cGunDirection)
 {
-    if (!IsLocalPlayer(pPedInterface))
+    SClientEntity<CPedSA>* pPedClientEntity = m_pools->GetPed((DWORD*)pPedInterface);
+    CPed*                  pAimingPed = pPedClientEntity ? pPedClientEntity->pEntity : nullptr;
+
+    if (!pAimingPed)
+        return;
+
+    if (!IsLocalPlayer(pAimingPed))
     {
         CRemoteDataStorageSA* data = CRemoteDataSA::GetRemoteDataStorage(pPedInterface);
         if (data)
@@ -168,6 +174,16 @@ VOID WriteGunDirectionDataForPed(CPedSAInterface* pPedInterface, float* fGunDire
             // Make sure our pitch is updated (fixes first-person weapons not moving)
             *fGunDirectionY = pGameInterface->GetCamera()->Find3rdPersonQuickAimPitch();
 
+            // Are we doing driveby?
+            if (pAimingPed->IsDoingGangDriveby())
+            {
+                // Fix pitch in driveby when facing left or backwards
+                if (LocalShotSyncData.m_cInVehicleAimDirection == 1 || LocalShotSyncData.m_cInVehicleAimDirection == 2)
+                {
+                    *fGunDirectionY = -*fGunDirectionY;
+                }
+            }
+
             LocalShotSyncData.m_fArmDirectionX = *fGunDirectionX;
             LocalShotSyncData.m_fArmDirectionY = *fGunDirectionY;
         }

Client/sdk/game/CPed.h

@@ -269,4 +269,5 @@ class CPed : public virtual CPhysical
     virtual void         AddWeaponAudioEvent(EPedWeaponAudioEventType audioEventType) = 0;
 
     virtual int GetCustomMoveAnim() = 0;
+    virtual bool IsDoingGangDriveby() = 0;
 };