ci(NODE-4856): break apart ts tests into separate tasks and skip failing tasks on typescript next #3474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
baileympearson
changed the title
nbbeeken
suggested changes
Nov 30, 2022
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
The comment about the echo is the only real one I feeling strongly about changing, otherwise lgtm
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks apart our typescript CI tasks into a task that checks compilation of the driver and a task that checks that our public types can be resolved.
This PR also skips any failing typescript tasks.