ci(NODE-4629): run csfle tests on serverless #3442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
changed the title
baileympearson
force-pushed
the
NODE-4629-run-csfle-tests-on-serverless
branch
from
456e1ab to
2604943
Compare
baileympearson
commented
Oct 18, 2022
| describe('Client Side Encryption (Unified)', function () { | ||
| installNode18DNSHooks(); | ||
| runUnifiedSuite(loadSpecTests(path.join('client-side-encryption', 'tests', 'unified'))); | ||
| runUnifiedSuite(loadSpecTests(path.join('client-side-encryption', 'tests', 'unified')), () => |
Contributor
Author
There was a problem hiding this comment.
changes in this file are necessary because we don't want to run the unified tests on serverless.
I considered breaking them into two separate files but decided against it for two reasons:
- our pattern is to keep legacy / unified tests together in the same file
- I wasn't sure how many places we ran just this file, and consequently how many places I might need to update if I broke them apart
baileympearson
changed the title
nbbeeken
added
the
Primary Review
nbbeeken
approved these changes
Oct 24, 2022
Comment on lines
+127
to
+135
| cat <<EOT > prepare_client_encryption.sh | ||
| export CLIENT_ENCRYPTION=${CLIENT_ENCRYPTION} | ||
| export CSFLE_KMS_PROVIDERS='${CSFLE_KMS_PROVIDERS}' | ||
| export AWS_ACCESS_KEY_ID='${AWS_ACCESS_KEY_ID}' | ||
| export AWS_SECRET_ACCESS_KEY='${AWS_SECRET_ACCESS_KEY}' | ||
| export AWS_DEFAULT_REGION='us-east-1' | ||
| export KMIP_TLS_CA_FILE="${DRIVERS_TOOLS}/.evergreen/x509gen/ca.pem" | ||
| export KMIP_TLS_CERT_FILE="${DRIVERS_TOOLS}/.evergreen/x509gen/client.pem" | ||
| EOT |
Contributor
There was a problem hiding this comment.
nbbeeken
added
Team Review
dariakp
approved these changes
Oct 24, 2022
ci: run csfle legacy tests on serverless
nbbeeken
force-pushed
the
NODE-4629-run-csfle-tests-on-serverless
branch
from
b46203f to
df7c943
Compare
ZLY201
pushed a commit
to ZLY201/node-mongodb-native
that referenced
this pull request
Nov 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/NODE-4629
Description
What is changing?
Legacy csfle tests now run on serverless.
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Good testing.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>