test(NODE-3011): lb support spec test changes #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
changed the title
durran
force-pushed
the
NODE-3011/spec-tests
branch
3 times, most recently
from
aca759a to
7a88a85
Compare
durran
commented
Jul 15, 2021
| return count + pool.currentCheckedOutCount; | ||
| }, 0); | ||
| expect(checkedOutConnections).to.equal(operation.arguments.connections); | ||
| // TODO: Durran: Fix in NODE-3011 |
Member
Author
There was a problem hiding this comment.
The count is implemented in the connection pool in NODE-3011 PR.
durran
commented
Jul 15, 2021
| const maybeIt = test.name.match(/Possible/) ? it.skip : it; | ||
| // TODO: Re-enable LoadBalanced in NODE-3011 | ||
| const maybeIt = | ||
| test.name.match(/Possible/) || topologyType === 'LoadBalanced' ? it.skip : it; |
durran
added
the
Primary Review
durran
force-pushed
the
NODE-3011/spec-tests
branch
3 times, most recently
from
ec009c7 to
b40f2c9
Compare
durran
force-pushed
the
NODE-3011/spec-tests
branch
from
b40f2c9 to
d92327a
Compare
dariakp
requested changes
Jul 15, 2021
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
Just noticed one thing, let me know if that's intentional
dariakp
approved these changes
Jul 15, 2021
dariakp
added
Team Review
nbbeeken
approved these changes
Jul 15, 2021
emadum
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes only the spec test changes from LB support.