Skip to content

refactor!(NODE-3295): Support node 12+ and reconfigure CI #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 2, 2021
Merged

refactor!(NODE-3295): Support node 12+ and reconfigure CI #2864

merged 11 commits into from
Jul 2, 2021

Conversation

@nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jun 25, 2021 •
edited
Loading

Changes

  • engine version reccomends node 12+
  • removed node 10 from test CI
  • simplified CI matrix
    • windows vs2019
    • ubuntu 18.04
    • macos 10.14
  • FLE runs on all systems (temporarily disabled pending release of required changes)
  • OCSP/TLS tests run on all OSes
  • Windows testing all versions of mongodb, there was a comment about skipping 4.2 but it is working now?
  • Extra variants moved to ubuntu for conistency. We can totally change our "default" OS version with a smalll script fix here. Ubuntu is required for LB so making it default makes sense there.
  • npm/node missing issue fixed by consolidating nvm-init to a script, it has to be setup differently on windows than other systems.
  • set PROJECT_DIRECTORY on tasks that don't use PREPARE_SHELL
  • refactored backtic usage
  • refactored assignment and export onliners

@nbbeeken nbbeeken changed the title NODE-3295/node-version refactor!(NODE-3295): Support node 12+ and reconfigure CI Jun 25, 2021
@nbbeeken nbbeeken force-pushed the NODE-3295/node-version branch from f44902e to 9c65171 Compare June 28, 2021 17:39
nbbeeken
nbbeeken commented Jun 28, 2021
View reviewed changes
tsconfig.json Outdated
"moduleResolution": "node",
"lib": ["ES2018"],
"skipLibCheck": true,
"lib": ["es2019", "es2020.promise", "es2020.bigint", "es2020.string"],
Copy link
Contributor Author

@nbbeeken nbbeeken Jun 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference: https://github.com/tsconfig/bases/blob/main/bases/node12.json
Also: https://stackoverflow.com/questions/59787574/typescript-tsconfig-settings-for-node-js-12/59787575#59787575

nbbeeken
nbbeeken commented Jun 28, 2021
View reviewed changes
package.json
"license": "Apache-2.0",
"engines": {
"node": ">=10"
"node": ">=12.9.0"
Copy link
Contributor Author

@nbbeeken nbbeeken Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This choice is based on:

Node 12.9 updated its v8 version: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2019-08-20-version-1290-current-targos

And these are the changes that it brings about: https://v8.dev/blog/v8-release-76

@nbbeeken nbbeeken requested a review from emadum June 28, 2021 20:07
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 28, 2021
@nbbeeken nbbeeken marked this pull request as ready for review June 28, 2021 20:07
emadum
emadum approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup and future-proofing! 🚀

.evergreen/generate_evergreen_tasks.js
const LATEST_EFFECTIVE_VERSION = '5.0';
const MONGODB_VERSIONS = ['latest', '4.4', '4.2', '4.0', '3.6', '3.4', '3.2', '3.0', '2.6'];
const NODE_VERSIONS = ['dubnium', 'erbium', 'fermium'];
const MONGODB_VERSIONS = ['latest', '5.0', '4.4', '4.2', '4.0', '3.6', '3.4', '3.2', '3.0', '2.6'];
Copy link
Contributor

@emadum emadum Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanted to point out this takes care of NODE-3306 (for 4.0 at least) - might want to capture that somehow.

Copy link
Contributor Author

@nbbeeken nbbeeken Jun 29, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like commit messge?

refactor!(NODE-3295): Support node 12+ and update CI targets

[add some notes about each point hit here, tsconfig, tests, os versions]
Resolves NODE-3306

and I can add a link on that ticket I linked the ticket to this PR, I guess the commit message would be on you if you think we want that, I think it would be good for history if it comes up

@emadum emadum added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 29, 2021
@emadum emadum requested a review from durran June 29, 2021 18:28
@emadum emadum merged commit fe71106 into 4.0 Jul 2, 2021
@emadum emadum deleted the NODE-3295/node-version branch July 2, 2021 19:24
@addaleax addaleax mentioned this pull request Jul 9, 2021
Merged
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
@nbbeeken @ljhaywar
refactor!(NODE-3295): Support node 12+ and reconfigure CI (#2864)
afa7bb9 
- Supported Node engine is now 12+
- No longer testing Node 10 in CI
- Simplified CI platform matrix: win64-vs2019/ubuntu-18.04/macos-10.14
- Run FLE/OCSP/TLS tests on all platforms
- Add server version 5.0 to the matrix (resolves NODE-3306)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@durran durran durran approved these changes

+1 more reviewer

@emadum emadum emadum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Team Review Needs review from team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nbbeeken @durran @emadum