chore(ci): xunit integration [3.5] #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emadum
changed the title
nbbeeken
approved these changes
Nov 30, 2020
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
nice to have this on all the branches! tyty!
mbroadst
suggested changes
Nov 30, 2020
lib/operations/command_v2.js
Outdated
Comment on lines
112
to
116
| function commandSupportsCollation(command) { | ||
| if (command.listCollections) return false; | ||
| return true; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
I think this sets a bit of a dangerous precedent, can we move this to the command construction of the listCollections operation? Ideally we would not ever depend on inspecting keys of command documents, hopefully we've designed the driver in such a way that we can make these determinations at the point of command construction, rather than at the wire protocol level.
test/functional/readconcern.test.js
Outdated
Comment on lines
63
to
65
| if (test.commandName === 'geoSearch') { | ||
| metadata.requires.mongodb += ' <=4.4'; | ||
| } |
Member
There was a problem hiding this comment.
This is a data-driven test, shouldn't the instructions for building the tests should be in the specs above rather than special cased here? Maybe something like serverVersion: '<=4.4'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of #2596 and #2612 for
3.5Note: also fixes a failing test on the latest server to get CI passing, related to setting collation on
listCollections.It seems we set collation a bit too aggressively and rely on the server ignoring it where it's not supported. However, the latest server version is returning an error: