Skip to content

Commit c9b30be

Browse files
Move the Reminder section of PR template to PR-Etiquette document (#279)
# Summary The reminder section of the PR template is supposed to be removed before merging the PR but we forget removing that most of the time and because of that we see that in the commit logs in master. And it also makes sense for that to be in the PR Etiquette document. That's why this PR removes that section from PR template and moves it to the PR Etiquette [document](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0#heading=h.f26xqmssh372). ## Proof of Work NA ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you checked for release_note changes?
1 parent 074b07c commit c9b30be

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

.github/pull_request_template.md

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,3 @@
1010
- [ ] Have you linked a jira ticket and/or is the ticket in the title?
1111
- [ ] Have you checked whether your jira ticket required DOCSP changes?
1212
- [ ] Have you checked for release_note changes?
13-
14-
## Reminder (Please remove this when merging)
15-
- Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
16-
- Our Short Guide for PRs: [Link](https://docs.google.com/document/d/1T93KUtdvONq43vfTfUt8l92uo4e4SEEvFbIEKOxGr44/edit?tab=t.0)
17-
- Remember the following Communication Standards - use comment prefixes for clarity:
18-
* **blocking**: Must be addressed before approval.
19-
* **follow-up**: Can be addressed in a later PR or ticket.
20-
* **q**: Clarifying question.
21-
* **nit**: Non-blocking suggestions.
22-
* **note**: Side-note, non-actionable. Example: Praise
23-
* --> no prefix is considered a question

0 commit comments

Comments
 (0)