Skip to content

Commit 3866bc9

Browse files
committed
Fix missing pipefail
1 parent d746a98 commit 3866bc9

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

.github/workflows/preview_release_notes.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,15 @@ jobs:
2727
python-version: '${{ vars.PYTHON_VERSION }}'
2828
- name: Generate Release Notes
2929
id: generate_release_notes
30-
run: |
31-
python -m scripts.release.release_notes -s $INITIAL_COMMIT_SHA -v $INITIAL_VERSION -o release_notes_tmp.md
30+
run: python -m scripts.release.release_notes -s $INITIAL_COMMIT_SHA -v $INITIAL_VERSION -o release_notes_tmp.md
3231
env:
3332
INITIAL_COMMIT_SHA: ${{ vars.RELEASE_INITIAL_COMMIT_SHA }}
3433
INITIAL_VERSION: ${{ vars.RELEASE_INITIAL_VERSION }}
3534
- name: Summarize results
3635
run: cat release_notes_tmp.md >> $GITHUB_STEP_SUMMARY
3736
- name: Update PR comment
3837
if: github.event_name == 'pull_request'
39-
run: |
40-
gh issue comment $ISSUE --edit-last --create-if-none --body-file release_notes_tmp.md
38+
run: gh issue comment $ISSUE --edit-last --create-if-none --body-file release_notes_tmp.md
4139
env:
4240
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4341
ISSUE: ${{ github.event.pull_request.html_url }}

.github/workflows/require_changelog.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ jobs:
2828
python-version: '${{ vars.PYTHON_VERSION }}'
2929
- name: Check if changelog entry file was added in this PR
3030
run: |
31+
set -o pipefail
3132
python -m scripts.release.check_changelog -b $BASE_SHA -f $FAIL_ON_NO_CHANGES | tee >> $GITHUB_STEP_SUMMARY
3233
env:
3334
BASE_SHA: ${{ github.event.pull_request.base.sha }}

0 commit comments

Comments
 (0)