CXX-3171 Remove obsolete export macros #1260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Nov 8, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
LGTM with no-longer-needed references to MONGOCXX_CALL and MONGOCXX_INLINE removed.
| #define MONGOCXX_INLINE inline MONGOCXX_ABI_NO_EXPORT | ||
|
|
||
| // For backward compatibility. Use MONGOCXX_ABI_EXPORT_CDECL instead. | ||
| #define MONGOCXX_CALL MONGOCXX_ABI_CDECL |
Collaborator
There was a problem hiding this comment.
Remove MONGOCXX_INLINE and MONGOCXX_CALL from prelude/postlude headers and macro guard checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves CXX-3171. Followup to #1202. Verified by this patch.
Removes all obsoleted export macros which have been superceded by
BSONCXX_ABI_EXPORT*macros.This uncovered some stray
BSONCXX_INLINEmacros which were missed by #1202. TheBSONCXX_DEPRECATED*_EXPORTmacros were also not being#undef'd properly, but given they're not expected to be used by anyone (including ourselves) this appears to have been a benign bug.