Reduce Warnings - Address warnings in examples and redundant recompilations #1201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
Sep 3, 2024
Collaborator
kevinAlbs
left a comment
kevinAlbs
left a comment
There was a problem hiding this comment.
The warning fixes are much appreciated.
examples/mongocxx/automatic_client_side_field_level_encryption.cpp
Outdated
Show resolved
Hide resolved
kevinAlbs
approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified by this patch.
Addresses 583 Clang warnings (157 unique) and 198 (7 unique) MSVC warnings relating to those emitted by examples (as part of CXX-2827). If a given warning was present in examples, this PR addresses it across all code for consistency.
404 Clang warnings and 191 MSVC warnings are addressed simply by reducing redundant recompilation of the new
client_helpersandspec_test_commonobject library components by various mongocxx test executables. None of these warnings were unique: they were just noisy repetition of the same warning. This refactor should reduce both the warning count and the overall compilation time for mongocxx test executables.Warnings pertaining to
__cdeclare deferred to CXX-3092.Warnings related to
_CRT_SECURE_NO_WARNINGSwith MSVC (getenv and gmtime) are left as-is. Feedback on how to approach these warnings (disable?#ifblocks? a platform-dependentBSONCXX_PRIVATE_GETENVmacro?) is welcome.