Skip to content

Conversation

@adriandole
Copy link
Contributor

@adriandole adriandole commented Jun 25, 2024

Addresses CXX-2828 and CXX-3014

Addresses several issues encountered attempting to run Range V2 tests:

  • Add a Debian 12 variant to test 8.0+ servers. No tasks were running a new enough server version to test Range V2.
  • Address compile issues encountered with GCC 12.
  • Apply fix to run QE/CSFLE tests (7101937). Tests were inadvertently skipped due to recent test runner changes (fb26981).

Addresses issues encountered upgrading to C driver 1.28.0:

  • Add -Wno-error=maybe-uninitialized to RHEL 7.9. Intended to ignore this RHEL 7.9 (gcc 4.8.5) build task error:

    ../../../mongo-c-driver-src/src/libmongoc/src/mongoc/mongoc-uri.c:489:15: error: 'tmp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
        } else if (*str) {
                   ^
    ../../../mongo-c-driver-src/src/libmongoc/src/mongoc/mongoc-uri.c:1419:16: note: 'tmp' was declared here
        const char *tmp;
                    ^
    

    This appears to be a false positive. The tmp on line 1419 is a different variable from the tmp in scope on 489. -Wno-error=maybe-uninitialized was added to the RHEL 7.9 distro.

  • Filed CXX-3112 to investigate a test failure with the legacy transactions test on sharded cluster tasks on 4.2. Appears unrelated to QE Range.

Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with pending suggestions addressed.

Updating the branch may fix failing 4.2 tasks with the fix of daf2d38. You can git merge master to avoid a rebase in the PR.

@kevinAlbs kevinAlbs self-requested a review October 1, 2024 10:32
@adriandole adriandole marked this pull request as ready for review October 1, 2024 16:46
@adriandole adriandole merged commit 0f990ca into mongodb:master Oct 1, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants