Use SKIP() in mongocxx::spec::run_tests_in_suite (#1226)

eramongodb · web-flow · commit 6810925c364b · 2024-10-04T10:33:30.000-05:00
diff --git a/src/mongocxx/test/spec/util.cpp b/src/mongocxx/test/spec/util.cpp
@@ -593,10 +593,10 @@ void run_tests_in_suite(std::string ev, test_runner cb, std::set<std::string> un
     while (std::getline(test_files, test_file)) {
         DYNAMIC_SECTION(test_file) {
             if (unsupported_tests.find(test_file) != unsupported_tests.end()) {
-                WARN("Skipping unsupported test file: " << test_file);
-            } else {
-                cb(path + "/" + test_file);
+                SKIP("Skipping unsupported test file: " << test_file);
             }
+
+            cb(path + "/" + test_file);
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -593,10 +593,10 @@ void run_tests_in_suite(std::string ev, test_runner cb, std::set<std::string> un`
`593`	`593`	`while (std::getline(test_files, test_file)) {`
`594`	`594`	`DYNAMIC_SECTION(test_file) {`
`595`	`595`	`if (unsupported_tests.find(test_file) != unsupported_tests.end()) {`
`596`		`- WARN("Skipping unsupported test file: " << test_file);`
`597`		`- } else {`
`598`		`- cb(path + "/" + test_file);`
	`596`	`+ SKIP("Skipping unsupported test file: " << test_file);`
`599`	`597`	`}`
	`598`	`+`
	`599`	`+ cb(path + "/" + test_file);`
`600`	`600`	`}`
`601`	`601`	`}`
`602`	`602`	`}`