Enforce C++ standard and visibility

Author: acmorrow

CMakeLists.txt

@@ -1,16 +1,30 @@
 # Versions < 2.8.8 do not support Object Libraries
-cmake_minimum_required(VERSION 3.1.0)
+cmake_minimum_required(VERSION 3.1.0 FATAL_ERROR)
 
 # Add in our modules
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake/")
 
-# Enforce the C++ standard
-set (CXX_STANDARD_REQUIRED true)
+# Enforce the C++ standard, and disable extensions
+set(CMAKE_CXX_STANDARD 11)
+set(CMAKE_CXX_EXTENSIONS OFF)
+
+# CMake 3.1 doesn't know how to C++11 for clang.
+if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11")
+else()
+  set(CMAKE_CXX_STANDARD_REQUIRED ON)
+endif()
 
 # Include the required modules
 include(GenerateExportHeader)
 include(InstallRequiredSystemLibraries)
 
+# If the user did not customize the install prefix,
+# set it to live under build so we don't inadverently pollute /usr/local
+if (CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT)
+    set (CMAKE_INSTALL_PREFIX "${CMAKE_BINARY_DIR}/install" CACHE PATH "default install path" FORCE )
+endif()
+
 # Ensure we have Package Config
 find_package(PkgConfig)
 
@@ -32,10 +46,6 @@ if (NOT CMAKE_BUILD_TYPE)
     set(CMAKE_BUILD_TYPE "Release")
 endif()
 
-set(CMAKE_CXX_FLAGS "-std=c++11 -Wall -Werror -fPIC ${CMAKE_CXX_FLAGS}")
-set(CMAKE_CXX_FLAGS_RELEASE "-O3")
-set(CMAKE_CXX_FLAGS_DEBUG "-ggdb3 -O0")
-
 if(BUILD_UNIT_TESTS)
     enable_testing()
 endif()

src/bsoncxx/CMakeLists.txt

@@ -65,8 +65,12 @@ add_library(bsoncxx SHARED
 
 set_target_properties (bsoncxx PROPERTIES
     OUTPUT_NAME bsoncxx
-    CXX_STANDARD 11
     VERSION ${BSONCXX_VERSION}
+    DEFINE_SYMBOL BSONCXX_EXPORTS
+    # uncomment when BSONCXX_API is applied as needed
+    # CXX_VISIBILITY_PRESET hidden
+    # VISIBILITY_INLINES_HIDDEN ON
+    #
     # uncomment this line when we start promising a stable ABI
     # SOVERSION ${BSONCXX_ABI_VERSION}
 )

src/mongocxx/CMakeLists.txt

@@ -49,8 +49,10 @@ add_library(mongocxx SHARED ${mongocxx_sources})
 
 set_target_properties (mongocxx PROPERTIES
     OUTPUT_NAME mongocxx
-    CXX_STANDARD 11
     VERSION ${MONGOCXX_VERSION}
+    DEFINE_SYMBOL MONGOCXX_EXPORTS
+    CXX_VISIBILITY_PRESET hidden
+    VISIBILITY_INLINES_HIDDEN ON
     # uncomment below line when we start promising a stable ABI
     # SOVERSION ${MONGOCXX_ABI_VERSION}
 )
@@ -62,7 +64,6 @@ if(BUILD_UNIT_TESTS)
 
     set_target_properties (mongocxx-mocked PROPERTIES
         OUTPUT_NAME mongocxx-mocked
-        CXX_STANDARD 11
         VERSION ${MONGOCXX_VERSION}
         SOVERSION ${MONGOCXX_ABI_VERSION}
         COMPILE_FLAGS "-DMONGOCXX_TESTING"