Skip to content

CSHARP-5014: Failed test: MongoDB.Driver.Tests.Specifications.transac… #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

CSHARP-5014: Failed test: MongoDB.Driver.Tests.Specifications.transac… #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/MongoDB.Driver.Tests/Specifications/Runner/MongoClientJsonDrivenSessionsTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,12 @@ protected void KillAllSessions()
protected IClientSessionHandle StartSession(IMongoClient client, BsonDocument test, string sessionKey)
{
var options = ParseSessionOptions(test, sessionKey);
return client.StartSession(options);
var session = client.StartSession(options);
if (LastKnownClusterTime != null)
{
session.WrappedCoreSession.AdvanceClusterTime(LastKnownClusterTime);
}
return session;
}

// private methods
Expand Down
17 changes: 15 additions & 2 deletions tests/MongoDB.Driver.Tests/Specifications/Runner/MongoClientJsonDrivenTestRunnerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ public abstract class MongoClientJsonDrivenTestRunnerBase : LoggableTestClass

protected IServer _failPointServer = null;

protected BsonDocument LastKnownClusterTime { get; set; }

// public constructors
public MongoClientJsonDrivenTestRunnerBase(ITestOutputHelper testOutputHelper)
: base(testOutputHelper)
Expand Down Expand Up @@ -218,8 +220,11 @@ protected virtual void CreateCollection(IMongoClient client, string databaseName
{
Logger.LogDebug("Creating collection {0} in {1} db", databaseName, collectionName);

var session = client.StartSession();
var database = client.GetDatabase(databaseName).WithWriteConcern(WriteConcern.WMajority);
database.CreateCollection(collectionName);
database.CreateCollection(session, collectionName);

LastKnownClusterTime = session.ClusterTime;
}

protected virtual MongoClient CreateClientForTestSetup()
Expand Down Expand Up @@ -288,13 +293,21 @@ protected virtual void InsertData(IMongoClient client, string databaseName, stri

if (shared.Contains(DataKey))
{
BsonDocument lastServerTime = null;
var documents = shared[DataKey].AsBsonArray.Cast<BsonDocument>().ToList();

if (documents.Count > 0)
{
var session = client.StartSession();

var database = client.GetDatabase(databaseName);
var collection = database.GetCollection<BsonDocument>(collectionName).WithWriteConcern(WriteConcern.WMajority);
collection.InsertMany(documents);
collection.InsertMany(session, documents);

lastServerTime = session.ClusterTime;
}

LastKnownClusterTime = lastServerTime ?? LastKnownClusterTime;
}
}

Expand Down