VS-99: Optimize MQL Generator to avoid having 1 using statement for each supported Bson Type

Author: Ravi-Raghavan

src/MongoDB.Analyzer.Helpers/Builders/MqlGenerator.cs

@@ -14,24 +14,12 @@
 
 using MongoDB.Driver;
 using System.Linq;
-using BsonDocumentCustom123 = MongoDB.Bson.BsonDocument;
-using BsonValueCustom123 = MongoDB.Bson.BsonValue;
-using BsonObjectIdCustom123 = MongoDB.Bson.BsonObjectId;
-using BsonTypeCustom123 = MongoDB.Bson.BsonType;
+using MongoDB.Bson;
 
 namespace MongoDB.Analyzer.Helpers.Builders
 {
     public static class MqlGenerator
     {
-#pragma warning disable CS0169 // The field is never used
-#pragma warning disable IDE0051
-        private static readonly BsonDocumentCustom123 s_dummyRef1;
-        private static readonly BsonValueCustom123 s_dummyRef2;
-        private static readonly BsonObjectIdCustom123 s_dummyRef3;
-        private static readonly BsonTypeCustom123 s_dummyRef4;
-#pragma warning restore IDE0051 // The field is never used
-#pragma warning restore CS0169
-
         private sealed class MqlGeneratorTemplateType
         {
             public int Field { get; set; }

src/MongoDB.Analyzer.Helpers/Linq/MqlGenerator.cs

@@ -15,6 +15,7 @@
 using System;
 using System.Linq;
 using MongoDB.Driver.Linq;
+using MongoDB.Bson;
 
 namespace MongoDB.Analyzer.Helpers.Linq
 {

src/MongoDB.Analyzer/Core/TypesGeneratorHelper.cs

@@ -22,11 +22,7 @@ internal static class TypesGeneratorHelper
         .AddUsings(
             Using("System"),
             Using("MongoDB.Bson"),
-            Using("MongoDB.Bson.Serialization.Attributes"),
-            Using("BsonTypeCustom123", "MongoDB.Bson.BsonType"),
-            Using("BsonDocumentCustom123", "MongoDB.Bson.BsonDocument"),
-            Using("BsonValueCustom123", "MongoDB.Bson.BsonValue"),
-            Using("BsonObjectIdCustom123", "MongoDB.Bson.BsonObjectId"));
+            Using("MongoDB.Bson.Serialization.Attributes"));
 
 
     private static readonly NamespaceDeclarationSyntax s_namespaceDeclarationSyntaxBuilders = SyntaxFactory.NamespaceDeclaration(SyntaxFactory.ParseName(MqlGeneratorSyntaxElements.Builders.MqlGeneratorNamespace));

src/MongoDB.Analyzer/Core/TypesProcessor.cs

@@ -16,14 +16,6 @@ namespace MongoDB.Analyzer.Core;
 
 internal sealed class TypesProcessor
 {
-    private static readonly Dictionary<string, string> s_knownTypes = new()
-    {
-        { "MongoDB.Bson.BsonDocument", "BsonDocumentCustom123" },
-        { "MongoDB.Bson.BsonValue", "BsonValueCustom123" },
-        { "MongoDB.Bson.BsonObjectId", "BsonObjectIdCustom123" },
-        { "MongoDB.Bson.BsonType", "BsonTypeCustom123" }
-    };
-
     private readonly Dictionary<string, (string NewName, MemberDeclarationSyntax NewDeclaration)> _processedTypes;
 
     private int _nextTypeId = 0;
@@ -43,9 +35,9 @@ public string GetTypeSymbolToGeneratedTypeMapping(ITypeSymbol typeSymbol)
         }
 
         var fullTypeName = GetFullName(typeSymbol);
-        if (s_knownTypes.TryGetValue(fullTypeName, out var knowTypeName))
+        if (typeSymbol.IsSupportedBsonType())
         {
-            return knowTypeName;
+            return typeSymbol.Name;
         }
 
         if (_processedTypes.TryGetValue(fullTypeName, out var result))
@@ -64,9 +56,9 @@ public string ProcessTypeSymbol(ITypeSymbol typeSymbol)
         }
 
         var fullTypeName = GetFullName(typeSymbol);
-        if (s_knownTypes.TryGetValue(fullTypeName, out var knowTypeName))
+        if (typeSymbol.IsSupportedBsonType())
         {
-            return knowTypeName;
+            return typeSymbol.Name;
         }
 
         if (_processedTypes.TryGetValue(fullTypeName, out var pair))

src/MongoDB.Analyzer/Core/Utilities/SymbolExtensions.cs

@@ -17,10 +17,20 @@ namespace MongoDB.Analyzer.Core;
 internal static class SymbolExtensions
 {
     private const string AssemblyMongoDBDriver = "MongoDB.Driver";
+    private const string NamespaceMongoDBBson = "MongoDB.Bson";
+
     private const string NamespaceMongoDBDriver = "MongoDB.Driver";
     private const string NamespaceMongoDBLinq = "MongoDB.Driver.Linq";
     private const string NamespaceSystemLinq = "System.Linq";
 
+    private static readonly HashSet<string> s_knownBsonTypes = new()
+    {
+        "MongoDB.Bson.BsonDocument",
+        "MongoDB.Bson.BsonValue",
+        "MongoDB.Bson.BsonObjectId",
+        "MongoDB.Bson.BsonType"
+    };
+
     private static readonly HashSet<string> s_supportedCollections = new()
     {
         "System.Collections.Generic.List<T>",
@@ -128,6 +138,10 @@ public static bool IsSupportedMongoCollectionType(this ITypeSymbol typeSymbol) =
         typeSymbol.TypeKind == TypeKind.Class &&
         !typeSymbol.IsAnonymousType;
 
+    public static bool IsSupportedBsonType(this ITypeSymbol typeSymbol) =>
+        typeSymbol?.ContainingNamespace?.ToDisplayString() == NamespaceMongoDBBson &&
+        s_knownBsonTypes.Contains(typeSymbol.ToDisplayString());
+
     public static bool IsString(this ITypeSymbol typeSymbol) =>
         typeSymbol?.SpecialType == SpecialType.System_String;