Exclude -Wpre-c11-compat warnings from public-header-warnings #2027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
approved these changes
Jun 3, 2025
| $<$<C_COMPILER_ID:AppleClang,Clang,GNU>:-Wno-declaration-after-statement> | ||
| $<$<C_COMPILER_ID:AppleClang,Clang,GNU>:-Wno-disabled-macro-expansion> | ||
| $<$<C_COMPILER_ID:AppleClang,Clang>:-Wno-c++98-compat-pedantic> | ||
| $<$<C_COMPILER_ID:AppleClang,Clang>:-Wno-pre-c11-compat> |
Contributor
There was a problem hiding this comment.
Does this break this target on Clang <19.0 ?
Contributor
Author
There was a problem hiding this comment.
It does not. -Wno-unknown-warning-option allows us to specify future warning flags even for old Clang versions.
eramongodb
added a commit
to eramongodb/mongo-c-driver
that referenced
this pull request
Jul 30, 2025
eramongodb
added a commit
that referenced
this pull request
Jul 31, 2025
* CDRIVER-5891 address implicit bool-to-null conversion in return statements (#1888) * CDRIVER-5891 extend C standard coverage up to C23 (#1890) * CDRIVER-5959 sync change streams unified spec tests with 0aee4aad (#1971) * CDRIVER-5304 set cluster time in test sessions (#2008) * Ignore -Wpre-c11-compat warnings when building public-header-warnings (#2027) * CDRIVER-6042 Migrate Python scripts from Poetry to Astral UV (#2039) * Migrate EVG task coverage to latest Debian, Ubuntu, and RHEL distros (#2044) * CDRIVER-6010 use `ec2.assume_role` for Azure KMS task (#2051) * CDRIVER-5971 Use Amazon ECR to obtain OCI images in EVG (#2058) * update Earthly version from 0.8.3 to 0.8.16 (#2072) --------- Co-authored-by: Kevin Albertson <[email protected]>
eramongodb
added a commit
to eramongodb/mongo-c-driver
that referenced
this pull request
Jul 31, 2025
eramongodb
added a commit
that referenced
this pull request
Jul 31, 2025
* CDRIVER-5959 temporarily restrict updateDescription tests to 8.1 or older (#1970) * CDRIVER-5959 sync change streams unified spec tests with 0aee4aad (#1971) * CDRIVER-5304 set cluster time in test sessions (#2008) * CDRIVER-6010 use `ec2.assume_role` for mongohouse task (#2025) * Ignore -Wpre-c11-compat warnings when building public-header-warnings (#2027) * CDRIVER-6042 Migrate Python scripts from Poetry to Astral UV (#2039) * Migrate EVG task coverage to latest Debian, Ubuntu, and RHEL distros (#2044) * CDRIVER-6010 use `ec2.assume_role` for Azure KMS task (#2051) * CDRIVER-5971 Use Amazon ECR to obtain OCI images in EVG (#2058) * CDRIVER-5874 Drop Debian 10 EVG task coverage (#2062) * update Earthly version from 0.8.3 to 0.8.16 (#2072) --------- Co-authored-by: Kevin Albertson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses C standard conformance task failures due to the
rhel93distro updating its system Clang compiler version from 16 to 19 (possibly by accident?). Clang 19 introduces a new-Wpre-c11-compatwarning which is triggering-Werrorcompilation errors when building thepublic-header-warningstarget. Regardless whether the upgrade was intentional or not, we should add this warning to our list anyways.