Fix truncate on models #1949
Merged
Fix truncate on models #1949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to docs array or object might be returned, so we need to add options. See https://docs.mongodb.com/php-library/v1.5/reference/method/MongoDBCollection-drop/
Closed
Giacomo92
approved these changes
Feb 8, 2020
Smolevich
approved these changes
Feb 8, 2020
mnphpexpert
added a commit
to mnphpexpert/laravel-mongodb
that referenced
this pull request
Sep 2, 2024
Fix truncate on models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to docs array or object might be returned on drop, so we need to add options.
See https://docs.mongodb.com/php-library/v1.5/reference/method/MongoDBCollection-drop
Related issue: #1948
However, not sure about
$this->assertEquals(1, $result);since truncate actually returns void https://github.com/laravel/framework/blob/6.x/src/Illuminate/Database/Query/Builder.php#L2804Closes #1948