test(NODE-6534): add spec test runner for Binary vector

Author: nbbeeken

test/node/bson_binary_vector.spec.test.ts

@@ -5,14 +5,6 @@ import { expect } from 'chai';
 
 const { toHex, fromHex } = BSON.onDemand.ByteUtils;
 
-const FLOAT = new Float64Array(1);
-const FLOAT_BYTES = new Uint8Array(FLOAT.buffer, 0, 8);
-
-FLOAT[0] = -1;
-// Little endian [0, 0, 0, 0, 0, 0,  240, 191]
-// Big endian    [191, 240, 0, 0, 0, 0, 0, 0]
-const isBigEndian = FLOAT_BYTES[7] === 0;
-
 type DTypeAlias = 'INT8' | 'FLOAT32' | 'PACKED_BIT';
 type VectorTest = {
   description: string;
@@ -25,36 +17,6 @@ type VectorTest = {
 };
 type VectorSuite = { description: string; test_key: string; tests: VectorTest[] };
 
-function validateVector(vector: Binary): void {
-  const VECTOR_TYPE = Object.freeze({
-    Int8: 0x03,
-    Float32: 0x27,
-    PackedBit: 0x10
-  } as const);
-
-  if (vector.sub_type !== 9) return;
-
-  const size = vector.position;
-  const d_type = vector.buffer[0] ?? 0;
-  const padding = vector.buffer[1] ?? 0;
-
-  if ((d_type === VECTOR_TYPE.Float32 || d_type === VECTOR_TYPE.Int8) && padding !== 0) {
-    throw new BSONError('Invalid Vector: padding must be zero for int8 and float32 vectors');
-  }
-
-  if (d_type === VECTOR_TYPE.PackedBit && padding !== 0 && size === 2) {
-    throw new BSONError(
-      'Invalid Vector: padding must be zero for packed bit vectors that are empty'
-    );
-  }
-
-  if (d_type === VECTOR_TYPE.PackedBit && padding > 7) {
-    throw new BSONError(
-      `Invalid Vector: padding must be a value between 0 and 7. found: ${padding}`
-    );
-  }
-}
-
 function fixFloats(f: string | number): number {
   if (typeof f === 'number') {
     return f;
@@ -97,34 +59,14 @@ function make(
   let binary: Binary;
   switch (dtype_alias) {
     case 'PACKED_BIT':
-    case 'INT8': {
-      const array = new Int8Array(vector.map(dtype_alias === 'INT8' ? fixInt8s : fixBits));
-      const buffer = new Uint8Array(array.byteLength + 2);
-      buffer[0] = +dtype_hex;
-      buffer[1] = padding;
-      buffer.set(new Uint8Array(array.buffer), 2);
-      binary = new Binary(buffer, 9);
+      binary = Binary.fromPackedBits(new Uint8Array(vector.map(fixBits)), padding);
       break;
-    }
-
-    case 'FLOAT32': {
-      const array = new Float32Array(vector.map(fixFloats));
-      const buffer = new Uint8Array(array.byteLength + 2);
-      buffer[0] = +dtype_hex;
-      buffer[1] = padding;
-      if (isBigEndian) {
-        for (let i = 0; i < array.length; i++) {
-          const bytes = new Uint8Array(array.buffer, i * 4, 4);
-          bytes.reverse();
-          buffer.set(bytes, i * 4 + 2);
-        }
-      } else {
-        buffer.set(new Uint8Array(array.buffer), 2);
-      }
-      binary = new Binary(buffer, 9);
+    case 'INT8':
+      binary = Binary.fromInt8Array(new Int8Array(vector.map(fixInt8s)));
+      break;
+    case 'FLOAT32':
+      binary = Binary.fromFloat32Array(new Float32Array(vector.map(fixFloats)));
       break;
-    }
-
     default:
       throw new Error(`Unknown dtype_alias: ${dtype_alias}`);
   }
@@ -188,8 +130,6 @@ describe('BSON Binary Vector spec tests', () => {
             try {
               const bin = make(test.vector, test.dtype_hex, test.dtype_alias, test.padding);
               BSON.serialize({ bin });
-              // TODO(NODE-6537): The following validation MUST be a part of serialize
-              validateVector(bin);
             } catch (error) {
               thrownError = error;
             }
@@ -205,8 +145,6 @@ describe('BSON Binary Vector spec tests', () => {
             try {
               const bin = make(test.vector, test.dtype_hex, test.dtype_alias, test.padding);
               BSON.EJSON.stringify({ bin });
-              // TODO(NODE-6537): The following validation MUST be a part of stringify
-              validateVector(bin);
             } catch (error) {
               thrownError = error;
             }