From 6bb3c6c26f0b3e16cf2a0dfaee8230d957a6acef Mon Sep 17 00:00:00 2001 From: Kyle Banker Date: Thu, 23 Feb 2012 13:08:31 -0500 Subject: [PATCH 1/9] minor: mongos config server ordering --- source/reference/mongos.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source/reference/mongos.rst b/source/reference/mongos.rst index d7d03b7518a..3ec501cc9fe 100644 --- a/source/reference/mongos.rst +++ b/source/reference/mongos.rst @@ -155,6 +155,11 @@ Options specify either 1 configuration server or 3 configuration servers, in a comma separated list. + Note that each mongos will read from the first config server in the + list provided. If you're running config servers across more than one + data center, you should specify the closest config servers as the first + servers in the list. + .. option:: --test This option is for internal testing use only, and runs unit tests From 1e07bae94eae41561ae18c294192a7e286254d13 Mon Sep 17 00:00:00 2001 From: Sam Kleinman Date: Thu, 23 Feb 2012 13:22:55 -0500 Subject: [PATCH 2/9] minor: sphinxifying mongos revision --- source/reference/mongos.rst | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/source/reference/mongos.rst b/source/reference/mongos.rst index 3ec501cc9fe..ebc6f3c7851 100644 --- a/source/reference/mongos.rst +++ b/source/reference/mongos.rst @@ -155,10 +155,13 @@ Options specify either 1 configuration server or 3 configuration servers, in a comma separated list. - Note that each mongos will read from the first config server in the - list provided. If you're running config servers across more than one - data center, you should specify the closest config servers as the first - servers in the list. + .. note:: + + Each :program:`mongos` reads from the first :term:`config server + ` in the list provided. If your configuration + databases reside in more that one data center, you should + specify the closest config servers as the first servers in the + list. .. option:: --test From 04250597afc7c37fc4ef6dcfb219a0dda6a97651 Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Fri, 24 Feb 2012 14:30:59 -0500 Subject: [PATCH 3/9] yum update and a minor typo. --- .../install-mongodb-on-redhat-centos-or-fedora-linux.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst b/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst index ee76e349c38..abf51e7e1f4 100644 --- a/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst +++ b/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst @@ -39,7 +39,7 @@ configuration and operation. Package Options --------------- -The 10gen repository contains for packages: +The 10gen repository contains four packages: - ``mongo-10gen`` @@ -83,6 +83,8 @@ Installing MongoDB Configure Package Management System (YUM) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +// TODO: please add instructions for yum update and that it needs to be executed after adding the repo. + Create a ``/etc/yum.repos.d/10gen.repo`` file to hold information about your repository. If you are running a 64-bit system (recommended,) place the following configuration in From 2dcf7405fc51b81f494f7576127c54c79acf3c51 Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Wed, 29 Feb 2012 18:45:48 -0500 Subject: [PATCH 4/9] Added some TODO's. --- source/tutorial/install-mongodb-on-linux.rst | 21 +++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/source/tutorial/install-mongodb-on-linux.rst b/source/tutorial/install-mongodb-on-linux.rst index b7c5bda2586..7da1dd57232 100644 --- a/source/tutorial/install-mongodb-on-linux.rst +++ b/source/tutorial/install-mongodb-on-linux.rst @@ -8,9 +8,9 @@ Synopsis -------- 10gen provides compiled versions of :term:`MongoDB` for use on Linux -that provides an simple option for users who cannot use packages. This +that provides a simple option for users who cannot use packages. This tutorial outlines the basic installation of MongoDB using these -packages and an initial usage guide. +compiled versions and an initial usage guide. .. seealso:: The documentation of following related processes and concepts. @@ -61,13 +61,17 @@ extract the files from the archive: You may use the following command to move the extracted folder into a more generic location. + //TODO: this is an installation guide for linux hence the package that will be downloaded + will probably have name like mongodb-linux-x86_64?-20??-??-?? + and not mongdo-osx-20??-??-?? that you have mentioned below. + .. code-block:: sh mv -n mongodb-osx-20??-??-??/ mongodb You can find the :program:`mongod` binary, and the binaries all of the associated MongoDB utilities, in the "``bin/``" directory within the -archive. +extracted directory. Using MongoDB ~~~~~~~~~~~~~ @@ -81,10 +85,18 @@ following command: mkdir -p /data/db +// TODO: you might want to mention that the users should also give write permissions + to the directory /data/db or wherever they want the dbpath to point to. + You can specify, and create, an alternate path using the :option:`--dbpath ` option to :program:`mongod` and the above command. +// TODO : the part to start mongod is completely missing. I think we should add a few lines + on how to start the mongod process. The previous step tells how to create a directory, + the next step tells how to use the mongo shell. We should definitely have a line on how to start + the mongod process. + The 10gen builds of MongoDB contain no :term:`control scripts ` or method to control the :program:`mongod` process. You may wish to create control scripts, modify your path, and/or create @@ -95,6 +107,9 @@ Among the tools included with this MongoDB distribution, is the :program:`mongo` shell. You can use this shell to connect to your MongoDB instance by issuing the following command at the system prompt: + + TODO : You might want to add that the following command is to be issued + from the directory in which mongodb was extracted to. './bin' is not very descritpive. .. code-block:: sh From 647fe07c923f5b95001b576e18320d603bafa842 Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Thu, 1 Mar 2012 12:56:53 -0500 Subject: [PATCH 5/9] Added a few TODO's --- source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst b/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst index 0a9b7f4a405..f46deedcc88 100644 --- a/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst +++ b/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst @@ -138,6 +138,10 @@ Controlling MongoDB Starting MongoDB ~~~~~~~~~~~~~~~~ +// TODO : Please add that the following commands should be run with root (sudo) privileges. + Running them without root privileges shows a weird message (it doesn't simply says + that run it with root, rather it gives some weird message. + Upstart users can start the :program:`mongod` process by issuing the following command: From 3566d10e66f3709614fc469991350919b222b1f9 Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Thu, 1 Mar 2012 13:18:11 -0500 Subject: [PATCH 6/9] Typos + added a line to 10gen.repo file --- ...nstall-mongodb-on-redhat-centos-or-fedora-linux.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst b/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst index abf51e7e1f4..c7ff286ed1e 100644 --- a/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst +++ b/source/tutorial/install-mongodb-on-redhat-centos-or-fedora-linux.rst @@ -96,6 +96,8 @@ about your repository. If you are running a 64-bit system name=10gen Repository baseurl=http://downloads-distro.mongodb.org/repo/redhat/os/x86_64 gpgcheck=0 + // TODO : Dan Crosta suggested that this line be added + enabled=1 If you are running a 32-bit system, which isn't recommended for production deployments, place the following configuration in @@ -107,6 +109,8 @@ production deployments, place the following configuration in name=10gen Repository baseurl=http://downloads-distro.mongodb.org/repo/redhat/os/i686 gpgcheck=0 + // TODO : Dan Crosta suggested that this line be added + enabled=1 Installing Packages ~~~~~~~~~~~~~~~~~~~ @@ -147,6 +151,8 @@ Start MongoDB Start the :program:`mongod` process by issuing the following command (as root, or with ``sudo``): +// TODO : should be service mongod start and not 'mongodb' start + .. code-block:: sh service mongodb start @@ -168,6 +174,8 @@ Stop MongoDB Stop the :program:`mongod` process by issuing the following command (as root, or with ``sudo``): +// TODO : should be service mongod stop and not 'mongodb' stop + .. code-block:: sh service mongodb stop @@ -178,6 +186,8 @@ Restart MongoDB You can restart the :program:`mongod` process by issuing the following command (as root, or with ``sudo``): +// TODO : should be service mongod restart and not 'mongodb' restart + .. code-block:: sh service mongodb restart From f0a18d2ce0dcd115d8f9ce5dcb3331877053e61d Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Thu, 1 Mar 2012 15:47:30 -0500 Subject: [PATCH 7/9] run with sudo privileges --- source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst b/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst index f46deedcc88..f4ffe86b916 100644 --- a/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst +++ b/source/tutorial/install-mongodb-on-debian-or-ubuntu-linux.rst @@ -139,8 +139,7 @@ Starting MongoDB ~~~~~~~~~~~~~~~~ // TODO : Please add that the following commands should be run with root (sudo) privileges. - Running them without root privileges shows a weird message (it doesn't simply says - that run it with root, rather it gives some weird message. + Upstart users can start the :program:`mongod` process by issuing the following command: From 73609079509be06263721f5a041a05d53c0074ac Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Fri, 2 Mar 2012 18:19:07 +0100 Subject: [PATCH 8/9] fork=true gives error saying that it muist be used with logpath --- source/tutorial/expand-replica-set.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/source/tutorial/expand-replica-set.rst b/source/tutorial/expand-replica-set.rst index 93c95c08b10..8cfd895bfc9 100644 --- a/source/tutorial/expand-replica-set.rst +++ b/source/tutorial/expand-replica-set.rst @@ -52,6 +52,10 @@ following is located on the file system at ``/etc/mongodb.conf``. replSet = rs0/mongodb0.example.net,mongodb1.example.net,mongodb2.example.net,mongodb3.example.net +//TODO : On using fork=true, I received an error saying that "--fork has to be used with --logpath" + Please verify + + Modify the :setting:`bind_ip` to reflect a secure interface on your system that will be able to access all other members of the set *and* on which all other members of the replica set can access the @@ -59,6 +63,9 @@ current node. The DNS or host names need to resolve to this IP address on the other members of the set. Configure network rules or a virtual private network (i.e. "VPN") to permit this access. +// TODO : Please also add a line about the port variable + + .. note:: The portion of the :setting:`replSet` following the ``/`` From 38b88433c9e9e7b675d0155377f2b65762598c50 Mon Sep 17 00:00:00 2001 From: Siddharth Singh Date: Mon, 5 Mar 2012 12:43:58 -0500 Subject: [PATCH 9/9] Update source/tutorial/deploy-geographically-distributed-replica-set.rst --- .../deploy-geographically-distributed-replica-set.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/source/tutorial/deploy-geographically-distributed-replica-set.rst b/source/tutorial/deploy-geographically-distributed-replica-set.rst index 33b5758c2de..fa0ecb277c9 100644 --- a/source/tutorial/deploy-geographically-distributed-replica-set.rst +++ b/source/tutorial/deploy-geographically-distributed-replica-set.rst @@ -55,9 +55,11 @@ following notes: Procedure --------- +// TODO : Can you please rewrite this sentence. Its clear what you are trying to say +but when read as a whole line, i feel as if it doesn't flow as a sentence. Although its possible to deploy multiple members on a single system, -reduces the redundancy and capacity of the system, these kinds of +it reduces the redundancy and capacity of the system, these kinds of deployments are typically for testing purposes and beyond the scope of this tutorial. @@ -176,7 +178,7 @@ configuration `: rs.config() Now, issue the following sequence of commands to add the remaining -members to the replica set. The following example assumes that the +members to the replica set. The following examrsple assumes that the current primary is ``mongodb0.example.net``. .. code-block:: javascript