Skip to content

Commit 9600909

Browse files
authored
README and PR template update (#20)
1 parent 5e4a88c commit 9600909

File tree

4 files changed

+71
-20
lines changed

4 files changed

+71
-20
lines changed

.github/pull_request_template.md

Lines changed: 5 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,13 @@
1-
## Pull Request Info
1+
# Pull Request Info
22

3-
### Issue JIRA link:
3+
[PR Reviewing Guidelines](https://github.com/mongodb/docs-visual-studio-extension/blob/master/REVIEWING.md)
44

5-
https://jira.mongodb.org/browse/DOCSP-NNNNN
5+
JIRA - <https://jira.mongodb.org/browse/DOCSP-NNNNN>
6+
Staging - <https://docs-mongodbcom-staging.corp.mongodb.com/drivers/docsworker-xlarge/NNNNN/>
67

7-
### Snooty build log:
8-
9-
**Paste your workerpool job link here**
10-
11-
### Docs staging link (requires sign-in on MongoDB Corp SSO):
12-
13-
https://docs-mongodborg-staging.corp.mongodb.com/golang/docsworker-xlarge/NNNNNNNNNNN/
14-
15-
### Self-Review Checklist
8+
## Self-Review Checklist
169

1710
- [ ] Is this free of any warnings or errors in the RST?
1811
- [ ] Did you run a spell-check?
1912
- [ ] Did you run a grammar-check?
20-
- [ ] Does it render on staging correctly?
2113
- [ ] Are all the links working?
22-
- [ ] Are the staging and workerpool job links in the PR description updated?
23-
24-
### If your page documents a concept, does it meet the following criteria?
25-
26-
- [ ] Target the [Jasmin persona](https://drive.google.com/file/d/14FbBOLCVxwSP6M9BK4Nz1Ir9tzxT8_02/view)
27-
- [ ] Target the [Lucas persona](https://drive.google.com/file/d/1J2vqJxo7ldv7OP_obA9Q-avf0o_ju4Lk/view)

README.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

README.rst

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
==============================
2+
MongoDB Analyzer Documentation
3+
==============================
4+
5+
This repository contains documentation for the MongoDB Analyzer.
6+
7+
8+
File JIRA Tickets
9+
-----------------
10+
11+
Please file issue reports or requests at the `Documentation Jira Project
12+
<https://jira.mongodb.org/browse/DOCS>`_.
13+
14+
Licenses
15+
--------
16+
17+
All documentation is available under the terms of a `Creative Commons
18+
License <https://creativecommons.org/licenses/by-nc-sa/3.0/>`_.
19+
20+
The MongoDB Documentation Project is governed by the terms of the
21+
`MongoDB Contributor Agreement
22+
<https://www.mongodb.com/legal/contributor-agreement>`_.
23+
24+
-- The MongoDB Docs Team

REVIEWING.md

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# Pull Request Reviewing Guidelines for MongoDB Analyzer Documentation
2+
3+
Contributions to the set of documents in this repository can receive reviews from one or both of the following types of reviews:
4+
5+
1. A **copy review**, which focuses on information structure and wording; typically performed by a MongoDB Documentation Team member
6+
2. A **technical review**, which addresses code snippets and the technical correctness of prose; typically performed by a MongoDB engineer.
7+
8+
See the following sections for reviewer expectations for each type of pull request (PR) review:
9+
10+
## Copy Review
11+
12+
Review the structure, wording, and flow of the information in the PR, and correct it if necessary.
13+
14+
### What to Review
15+
16+
- Wording
17+
- Page structure
18+
- Technical content to the extent of the reviewer’s understanding.
19+
- Whether the PR fulfills the Acceptance Criteria described in the
20+
linked JIRA ticket.
21+
22+
### What Not to Review
23+
24+
Nothing is completely off-limits to a copy review of a PR -- if you notice a technical issue, it's best to call it out early.
25+
Copy reviewers should constrain their reviews to content within the scope of the JIRA ticket, or otherwise create PRs to address anything unrelated.
26+
27+
## Technical Review
28+
29+
Review the technical accuracy and completeness of a PR and correct it if necessary.
30+
31+
### What to Review
32+
33+
- Code snippets; ensure the code is idiomatic and that all technical claims are correct. e.g. ("To create a `Foo`, use the `Bar.createFoo()` method")
34+
- Problematic explanations that could trip up users who try to follow the documentation.
35+
36+
### What Not to Review
37+
38+
While we welcome any recommendations on wording and structure, avoid blocking approval based on any copy edits. Please entrust the author to make the writing decisions based on style guidelines and team-specific writing conventions, and to create PRs to address anything they deem outside the technical review scope.
39+
40+
- Wording of sentences, although corrections to technical claims are welcome
41+
- Structure of the page
42+
- Any unchanged lines outside the PR unless relevant to the ticket acceptance criteria.

0 commit comments

Comments
 (0)