Skip to content

Commit 84de9c9

Browse files
Apply suggestions from code review
Internal review feedback Co-authored-by: Ashley Brown <[email protected]>
1 parent 514e3a0 commit 84de9c9

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

source/includes/fact-data-prep-oracle-step1.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ a. Create a service account:
1717
1818
CREATE USER '<user>'@'localhost' IDENTIFIED BY '<password>';
1919
20-
#. Check if the service account owns the tables in the migration job.
20+
#. Confirm that the service account owns the tables in the migration job.
2121

2222
Required permissions depend on whether the service account owns the tables
23-
used in the migration job. To check table ownership run the following query:
23+
used in the migration job. To check table ownership, run the following query:
2424

2525
.. code-block:: sql
2626
:copyable: true
@@ -35,7 +35,7 @@ a. Create a service account:
3535
.. important::
3636

3737
If you're migrating a multi-tenant container database as a
38-
common user, append ``CONTAINER=ALL`` when granting permissions, for
38+
common user, append ``CONTAINER=ALL`` when granting permissions. For
3939
example:
4040

4141
.. code-block:: sql
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
- Snapshot migration jobs migrate all data, then stop.
2-
- Continuous migration job run a snapshot and then enter a CDC stage to
3-
continuously replicate data changes.
1+
- Snapshot migration jobs migrate all data once, and then stop.
2+
- Continuous migration jobs run a snapshot migration and then enter a CDC stage, which
3+
continuously replicates data changes.

source/jobs/prerequisites/oracle.txt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ Configure Migration Prerequisites for Oracle
1010
:depth: 1
1111
:class: singlecol
1212

13-
When migrating data from an Oracle source database, the database may require
13+
When you migrate data from an Oracle source database, that database may require
1414
configuration changes. If Relational Migrator determines the
1515
database needs configuration changes, it automatically generates a
1616
SQL script with the required changes. Have a Database Administrator (DBA)
17-
review the script, then have them run the commands on the database server.
17+
review the script and run the commands on the database server.
1818

1919
Oracle configuration depends on the type of migration job:
2020

@@ -28,15 +28,15 @@ About this Task
2828

2929
- If you're migrating from an Oracle 12c instance, you must run commands as
3030
the SYSDBA role.
31-
- Oracle 12c introduced the concept of a pluggable database. Some
31+
- Oracle 12c introduced the concept of a pluggable database (PDB). Some
3232
of these commands can be run on a PDB (pluggable database), while commands
33-
such as enabling ``ARCHIVELOG`` must be run on the
34-
CDB (container/master database). For details on each architecture,
33+
like enabling ``ARCHIVELOG`` must be run on the
34+
container/master database (CDB). For details on each architecture,
3535
see `Overview of Container Databases and Pluggable Databases
3636
<https://oracle-base.com/articles/12c/multitenant-overview-container-database-cdb-12cr1>`__.
3737
- Some commands differ based on whether the database is single or
3838
multi-tenant. In a multi-tenant database, permissions must
39-
include the suffix ``CONTAINER=ALL``
39+
include the suffix ``CONTAINER=ALL``.
4040
- Oracle Express editions don't support logging the necessary information for
4141
continuous migration jobs, so you can't run continuous migration against an
4242
Oracle XE database.
@@ -98,7 +98,7 @@ Steps
9898

9999
.. step:: Turn on archive logging
100100

101-
a. To check if archive logging is already enabled, run the following query:
101+
a. To see if archive logging is already enabled, run the following query:
102102

103103
.. code-block:: sql
104104
:copyable: true
@@ -108,10 +108,10 @@ Steps
108108
This outputs ``ARCHIVELOG`` if logging is enabled, or
109109
``NOARCHIVELOG`` if it isn't.
110110

111-
#. Enable archive logging if it isn't already enabled.
111+
#. If archive logging isn't already enabled, enable it.
112112

113113
The following is an example of the code Relational Migrator
114-
generates for enabling logging, which you can run manually by
114+
The following code is an example. You can run it manually if you
115115
substituting your database name. If you're migrating a
116116
multi-tenant database, run these commands on the
117117
container/master database.
@@ -128,7 +128,7 @@ Steps
128128

129129
.. step:: Enable supplemental logging
130130

131-
a. To run continuous migration jobs against Oracle, enable
131+
a. Enable
132132
supplemental logging:
133133

134134
.. code-block:: sql

0 commit comments

Comments
 (0)