Skip to content

Conversation

@rustagir
Copy link
Contributor

@rustagir rustagir commented Jun 28, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-30481
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Question:

I noticed some other instances of java.util.Date such as in:
https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30481-localdatetime/fundamentals/builders/updates/
Should these be replaced as well?

@rustagir
Copy link
Contributor Author

LGTM! Question:

I noticed some other instances of java.util.Date such as in: https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30481-localdatetime/fundamentals/builders/updates/ Should these be replaced as well?

I can't find what you are referencing on that page. The Date instances on that page were replaced when I worked on it earlier this month.

@rustagir rustagir merged commit baabb3c into mongodb:master Jun 30, 2023
rustagir added a commit that referenced this pull request Jun 30, 2023
# Pull Request Info

[PR Reviewing
Guidelines](https://github.com/mongodb/docs-java/blob/master/REVIEWING.md)

JIRA - https://jira.mongodb.org/browse/DOCSP-30481
Staging:
-
[Documents](https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30481-localdatetime/fundamentals/data-formats/documents/)
- [Extended
JSON](https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30481-localdatetime/fundamentals/data-formats/document-data-format-extended-json/)

## Self-Review Checklist

- [ ] Is this free of any warnings or errors in the RST?
- [ ] Did you run a spell-check?
- [ ] Did you run a grammar-check?
- [ ] Are all the links working?

(cherry picked from commit baabb3c)
@docs-builder-bot
Copy link
Collaborator

@ccho-mongodb
Copy link
Contributor

LGTM! Question:
I noticed some other instances of java.util.Date such as in: https://docs-mongodbcom-staging.corp.mongodb.com/kotlin/docsworker-xlarge/DOCSP-30481-localdatetime/fundamentals/builders/updates/ Should these be replaced as well?

I can't find what you are referencing on that page. The Date instances on that page were replaced when I worked on it earlier this month.

Strange, I was seeing it on the original staging link, but not anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants