Skip to content

Conversation

@mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jun 26, 2024

Pull Request Info

Largely based off the Go version of the page, with a little Java version sprinkled in.

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-40574
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/csharp/docsworker-xlarge/DOCSP-40574-geo/fundamentals/geo

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small tweaks but otherwise LGTM!

.Include(m => m.Plot));

The results of the preeding example contain the following documents:
The results of the preceding example contain the following documents:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on this typo!

@mcmorisi mcmorisi requested a review from BorisDog July 2, 2024 16:51
Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

Overview
--------

In this guide, you can learn how to work with **geospatial data** formats,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should be "work with geospatial data, data formats ...".


.. important:: Longitude then Latitude

GeoJSON orders coordinates with longitude first and latitude second.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also adding GeoJson.Geographic(-73.986805, 40.7620853) example, with GeoJson.Geographic geographic coordinates names are used: longitude and longitude

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a little more detail on this? A little unsure on how you would incorporate this example (also you say "longitude and longitude" here).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, lon and lon is a typo;

There is a method in our GeoJson class, GeoJson.Geographic for constructing coordinates with Longitude and Latitude properties. It's equivalent, to Position, just different naming for clarity. We could mentioned that as well.

{ "_id" : ObjectId("59a47286cfa9a3a73e51e838"), "theaterId" : 1448 }

Query by Polygon
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be:

Query by Polygon
~~~~~~~~~~~~

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@mcmorisi mcmorisi requested a review from BorisDog July 3, 2024 16:55
Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmorisi mcmorisi merged commit 627d6ec into mongodb:master Jul 5, 2024
@mcmorisi mcmorisi deleted the DOCSP-40574-geo branch July 5, 2024 12:58
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mcmorisi added a commit that referenced this pull request Jul 5, 2024
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants