-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-40574: Add Geospatial page #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
caitlindavey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small tweaks but otherwise LGTM!
| .Include(m => m.Plot)); | ||
|
|
||
| The results of the preeding example contain the following documents: | ||
| The results of the preceding example contain the following documents: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch on this typo!
BorisDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor comments.
source/fundamentals/geo.txt
Outdated
| Overview | ||
| -------- | ||
|
|
||
| In this guide, you can learn how to work with **geospatial data** formats, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should be "work with geospatial data, data formats ...".
|
|
||
| .. important:: Longitude then Latitude | ||
|
|
||
| GeoJSON orders coordinates with longitude first and latitude second. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider also adding GeoJson.Geographic(-73.986805, 40.7620853) example, with GeoJson.Geographic geographic coordinates names are used: longitude and longitude
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you provide a little more detail on this? A little unsure on how you would incorporate this example (also you say "longitude and longitude" here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, lon and lon is a typo;
There is a method in our GeoJson class, GeoJson.Geographic for constructing coordinates with Longitude and Latitude properties. It's equivalent, to Position, just different naming for clarity. We could mentioned that as well.
source/fundamentals/geo.txt
Outdated
| { "_id" : ObjectId("59a47286cfa9a3a73e51e838"), "theaterId" : 1448 } | ||
|
|
||
| Query by Polygon | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
Query by Polygon
~~~~~~~~~~~~
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
BorisDog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
(cherry picked from commit 627d6ec)
Pull Request Info
Largely based off the Go version of the page, with a little Java version sprinkled in.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-40574
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/csharp/docsworker-xlarge/DOCSP-40574-geo/fundamentals/geo
Self-Review Checklist