fix: COMPASS-4209: Add missing returns on error cases (#69)

imlucas · web-flow · commit 407d1dc8fd6a · 2020-04-14T09:03:38.000-04:00
diff --git a/lib/fetch.js b/lib/fetch.js
@@ -33,7 +33,9 @@ function getIndexes(results, done) {
     .collection(ns.collection)
     .indexes(function(err, indexes) {
       if (err) {
+        debug('getIndexes failed!', err);
         done(err);
+        return;
       }
       // add ns field to each index
       _.each(indexes, function(idx) {
@@ -80,7 +82,8 @@ function getIndexStats(results, done) {
         debug('$indexStats not yet supported, return empty document', err);
         return done(null, {});
       }
-      done(err);
+      debug('Unknown error while getting index stats!', err);
+      return done(err);
     }
     res = _.mapKeys(res, function(stat) {
       return stat.name;

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,9 @@ function getIndexes(results, done) {`
`33`	`33`	`.collection(ns.collection)`
`34`	`34`	`.indexes(function(err, indexes) {`
`35`	`35`	`if (err) {`
	`36`	`+ debug('getIndexes failed!', err);`
`36`	`37`	`done(err);`
	`38`	`+ return;`
`37`	`39`	`}`
`38`	`40`	`// add ns field to each index`
`39`	`41`	`_.each(indexes, function(idx) {`
`@@ -80,7 +82,8 @@ function getIndexStats(results, done) {`
`80`	`82`	`debug('$indexStats not yet supported, return empty document', err);`
`81`	`83`	`return done(null, {});`
`82`	`84`	`}`
`83`		`- done(err);`
	`85`	`+ debug('Unknown error while getting index stats!', err);`
	`86`	`+ return done(err);`
`84`	`87`	`}`
`85`	`88`	`res = _.mapKeys(res, function(stat) {`
`86`	`89`	`return stat.name;`