Skip to content

Commit cbb9d01

Browse files
authored
chore(databases-collection): refactor create db / create coll to a single create namespace plugin COMPASS-7410 (#5100)
* chore(databases-collection): refactor create db / create coll to a single create namespace plugin * chore(databases-collections): re-introduce old tests; add plugin service mock helper; add new plugin tests * chore(app-registry): use scoped globalAppRegistry in withMockedServices helper * chore(instance): off -> removeListener * chore(databases-collections): only reset relevant state on open
1 parent da91b3e commit cbb9d01

39 files changed

+806
-1743
lines changed

package-lock.json

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/compass-home/src/components/home.spec.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ const createDataService = () => ({
3939
setName: 'foo',
4040
};
4141
},
42+
configuredKMSProviders() {
43+
return [];
44+
},
4245
on() {},
4346
off() {},
4447
});

packages/compass-home/src/components/home.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,7 @@ import { CompassSettingsPlugin } from '@mongodb-js/compass-settings';
4343
import { CreateViewPlugin } from '@mongodb-js/compass-aggregations';
4444
import { CompassFindInPagePlugin } from '@mongodb-js/compass-find-in-page';
4545
import {
46-
CreateDatabasePlugin,
47-
CreateCollectionPlugin,
46+
CreateNamespacePlugin,
4847
DropNamespacePlugin,
4948
} from '@mongodb-js/compass-databases-collections';
5049
import { ImportPlugin, ExportPlugin } from '@mongodb-js/compass-import-export';
@@ -361,6 +360,7 @@ function Home({
361360
<ImportPlugin></ImportPlugin>
362361
<ExportPlugin></ExportPlugin>
363362
<CreateViewPlugin></CreateViewPlugin>
363+
<CreateNamespacePlugin></CreateNamespacePlugin>
364364
<DropNamespacePlugin></DropNamespacePlugin>
365365
<Workspace
366366
namespace={namespace}
@@ -391,8 +391,6 @@ function Home({
391391
</div>
392392
<CompassSettingsPlugin></CompassSettingsPlugin>
393393
<CompassFindInPagePlugin></CompassFindInPagePlugin>
394-
<CreateDatabasePlugin></CreateDatabasePlugin>
395-
<CreateCollectionPlugin></CreateCollectionPlugin>
396394
<AtlasSignIn></AtlasSignIn>
397395
</SignalHooksProvider>
398396
);

packages/databases-collections/package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@
4747
"reformat": "npm run prettier -- --write . && npm run eslint . --fix"
4848
},
4949
"peerDependencies": {
50+
"@mongodb-js/compass-app-stores": "^7.6.1",
5051
"@mongodb-js/compass-components": "^1.19.0",
5152
"@mongodb-js/compass-editor": "^0.18.0",
5253
"@mongodb-js/compass-logging": "^1.2.6",
@@ -87,6 +88,7 @@
8788
"sinon": "^9.2.3"
8889
},
8990
"dependencies": {
91+
"@mongodb-js/compass-app-stores": "^7.6.1",
9092
"@mongodb-js/compass-components": "^1.19.0",
9193
"@mongodb-js/compass-editor": "^0.18.0",
9294
"@mongodb-js/compass-logging": "^1.2.6",

packages/databases-collections/src/components/create-collection-modal/create-collection-modal.jsx

Lines changed: 0 additions & 105 deletions
This file was deleted.

packages/databases-collections/src/components/create-collection-modal/create-collection-modal.spec.jsx

Lines changed: 0 additions & 85 deletions
This file was deleted.

packages/databases-collections/src/components/create-collection-modal/index.js

Lines changed: 0 additions & 5 deletions
This file was deleted.

0 commit comments

Comments
 (0)