Skip to content

Commit c4c13cc

Browse files
Get rid of maven-artifact-transfer from dependencies
m-artifact-t was only used for dependencies resolving
1 parent ba8c068 commit c4c13cc

File tree

2 files changed

+21
-29
lines changed

2 files changed

+21
-29
lines changed

pom.xml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -155,12 +155,6 @@
155155
<artifactId>commons-exec</artifactId>
156156
<version>1.3</version>
157157
</dependency>
158-
159-
<dependency>
160-
<groupId>org.apache.maven.shared</groupId>
161-
<artifactId>maven-artifact-transfer</artifactId>
162-
<version>0.13.1</version>
163-
</dependency>
164158

165159
<dependency>
166160
<groupId>junit</groupId>

src/main/java/org/codehaus/mojo/exec/ExecJavaMojo.java

Lines changed: 21 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import java.util.Collection;
1313
import java.util.Collections;
1414
import java.util.HashSet;
15-
import java.util.LinkedHashSet;
1615
import java.util.List;
1716
import java.util.Properties;
1817
import java.util.Set;
@@ -21,19 +20,18 @@
2120
import java.util.concurrent.ForkJoinPool;
2221

2322
import org.apache.maven.artifact.Artifact;
23+
import org.apache.maven.artifact.resolver.ArtifactResolutionException;
24+
import org.apache.maven.artifact.resolver.ArtifactResolutionRequest;
25+
import org.apache.maven.artifact.resolver.ArtifactResolutionResult;
26+
import org.apache.maven.artifact.resolver.ResolutionErrorHandler;
2427
import org.apache.maven.plugin.MojoExecutionException;
2528
import org.apache.maven.plugin.MojoFailureException;
2629
import org.apache.maven.plugins.annotations.Component;
2730
import org.apache.maven.plugins.annotations.Mojo;
2831
import org.apache.maven.plugins.annotations.Parameter;
2932
import org.apache.maven.plugins.annotations.ResolutionScope;
30-
import org.apache.maven.project.MavenProject;
3133
import org.apache.maven.project.ProjectBuilder;
32-
import org.apache.maven.project.ProjectBuildingRequest;
33-
import org.apache.maven.shared.artifact.filter.resolve.AndFilter;
34-
import org.apache.maven.shared.artifact.filter.resolve.TransformableFilter;
35-
import org.apache.maven.shared.transfer.artifact.resolve.ArtifactResult;
36-
import org.apache.maven.shared.transfer.dependencies.resolve.DependencyResolver;
34+
import org.apache.maven.repository.RepositorySystem;
3735

3836
/**
3937
* Executes the supplied java class in the current VM with the enclosing project's dependencies as classpath.
@@ -46,7 +44,10 @@ public class ExecJavaMojo
4644
extends AbstractExecMojo
4745
{
4846
@Component
49-
private DependencyResolver dependencyResolver;
47+
private RepositorySystem repositorySystem;
48+
49+
@Component
50+
private ResolutionErrorHandler resolutionErrorHandler;
5051

5152

5253
/**
@@ -702,29 +703,26 @@ private Set<Artifact> determineRelevantPluginDependencies()
702703
private Set<Artifact> resolveExecutableDependencies( Artifact executablePomArtifact )
703704
throws MojoExecutionException
704705
{
705-
706-
Set<Artifact> executableDependencies = new LinkedHashSet<>();
707706
try
708707
{
709-
ProjectBuildingRequest buildingRequest = getSession().getProjectBuildingRequest();
710-
711-
MavenProject executableProject =
712-
this.projectBuilder.build( executablePomArtifact, buildingRequest ).getProject();
708+
ArtifactResolutionRequest request = new ArtifactResolutionRequest()
709+
.setArtifact( executablePomArtifact )
710+
.setLocalRepository( getSession().getLocalRepository() )
711+
.setRemoteRepositories( getSession().getRequest().getRemoteRepositories() )
712+
.setForceUpdate( getSession().getRequest().isUpdateSnapshots() )
713+
.setOffline( getSession().isOffline() )
714+
.setResolveTransitively( true );
713715

714-
for ( ArtifactResult artifactResult : dependencyResolver.resolveDependencies( buildingRequest,
715-
executableProject.getModel(),
716-
new AndFilter( Collections.<TransformableFilter>emptyList() ) ) )
717-
{
718-
executableDependencies.add( artifactResult.getArtifact() );
719-
}
716+
ArtifactResolutionResult result = repositorySystem.resolve( request );
717+
resolutionErrorHandler.throwErrors( request, result );
718+
719+
return result.getArtifacts();
720720
}
721-
catch ( Exception ex )
721+
catch ( ArtifactResolutionException ex )
722722
{
723723
throw new MojoExecutionException( "Encountered problems resolving dependencies of the executable "
724724
+ "in preparation for its execution.", ex );
725725
}
726-
727-
return executableDependencies;
728726
}
729727

730728
/**

0 commit comments

Comments
 (0)