PHP84: preg_match(): Passing null to parameter laravel#2 ($subject) of type string is deprecated

tivvie · tivvie · commit 1a02051f73d3 · 2025-09-24T13:51:26.000+02:00
diff --git a/src/Illuminate/Routing/UrlGenerator.php b/src/Illuminate/Routing/UrlGenerator.php
@@ -674,7 +674,10 @@ public function format($root, $path, $route = null)
      */
     public function isValidUrl($path)
     {
-        if (! preg_match('~^(#|//|https?://|(mailto|tel|sms):)~', $path)) {
+        if (
+            $path !== null
+            && !preg_match('~^(#|//|https?://|(mailto|tel|sms):)~', $path)
+        ) {
             return filter_var($path, FILTER_VALIDATE_URL) !== false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -674,7 +674,10 @@ public function format($root, $path, $route = null)`
`674`	`674`	`*/`
`675`	`675`	`public function isValidUrl($path)`
`676`	`676`	`{`
`677`		`- if (! preg_match('~^(#\|//\|https?://\|(mailto\|tel\|sms):)~', $path)) {`
	`677`	`+ if (`
	`678`	`+ $path !== null`
	`679`	`+ && !preg_match('~^(#\|//\|https?://\|(mailto\|tel\|sms):)~', $path)`
	`680`	`+ ) {`
`678`	`681`	`return filter_var($path, FILTER_VALIDATE_URL) !== false;`
`679`	`682`	`}`
`680`	`683`