PHP84: preg_match(): Passing null to parameter laravel#2 ($subject) of type string is deprecated

tivvie · tivvie · commit 0e088b220245 · 2025-11-03T12:49:39.000+01:00
diff --git a/src/Illuminate/Routing/UrlGenerator.php b/src/Illuminate/Routing/UrlGenerator.php
@@ -677,7 +677,10 @@ public function format($root, $path, $route = null)
      */
     public function isValidUrl($path)
     {
-        if (! preg_match('~^(#|//|https?://|(mailto|tel|sms):)~', $path)) {
+        if (
+            $path !== null
+            && !preg_match('~^(#|//|https?://|(mailto|tel|sms):)~', $path)
+        ) {
             return filter_var($path, FILTER_VALIDATE_URL) !== false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -677,7 +677,10 @@ public function format($root, $path, $route = null)`
`677`	`677`	`*/`
`678`	`678`	`public function isValidUrl($path)`
`679`	`679`	`{`
`680`		`- if (! preg_match('~^(#\|//\|https?://\|(mailto\|tel\|sms):)~', $path)) {`
	`680`	`+ if (`
	`681`	`+ $path !== null`
	`682`	`+ && !preg_match('~^(#\|//\|https?://\|(mailto\|tel\|sms):)~', $path)`
	`683`	`+ ) {`
`681`	`684`	`return filter_var($path, FILTER_VALIDATE_URL) !== false;`
`682`	`685`	`}`
`683`	`686`