[auth] Fix march spec fallback for metadata discovery #1108
+75
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
felixweinberger
approved these changes
Nov 13, 2025
Contributor
felixweinberger
left a comment
felixweinberger
left a comment
There was a problem hiding this comment.
Thanks! Pushed a small commit running eslint
felixweinberger
added a commit
that referenced
this pull request
Nov 13, 2025
Co-authored-by: Felix Weinberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
fixes #1103
In #1070 we switched to only doing path or root based URLs, but this broke legacy servers because we were using the wrong "auth server url" for that scenario.
How Has This Been Tested?
Added unit tests.
Also checked against JIRA and Linear via:
Breaking Changes
No, unbreaks main
Types of changes
Checklist
Additional context
I also tested this against new conformance tests in this PR:
modelcontextprotocol/conformance#28