Skip to content

fix: streamable http server close request channel on response(#266) #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025
+11 −3
Merged

fix: streamable http server close request channel on response(#266) #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c396530
fix: improve resource unregistration logic in LocalSessionWorker
4t145 Jun 18, 2025
8e8f850
fix: fix typo
4t145 Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions crates/rmcp/src/transport/streamable_http_server/session/local.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,11 +328,19 @@ impl LocalSessionWorker {
if let Some(http_request_id) = self.resource_router.remove(resource) {
tracing::trace!(?resource, http_request_id, "unregister resource");
if let Some(channel) = self.tx_router.get_mut(&http_request_id) {
channel.resources.remove(resource);
if channel.resources.is_empty() {
// It's okey to do so, since we don't handle batch json rpc request anymore
// and this can be refactored after the batch request is removed in the coming version.
if channel.resources.is_empty() || matches!(resource, ResourceKey::McpRequestId(_))
{
tracing::debug!(http_request_id, "close http request wise channel");
self.tx_router.remove(&http_request_id);
if let Some(channel) = self.tx_router.remove(&http_request_id) {
for resource in channel.resources {
self.resource_router.remove(&resource);
}
}
}
} else {
tracing::warn!(http_request_id, "http request wise channel not found");
}
}
}
Expand Down