feat: allow failable service creation in streamable HTTP tower service #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our setup we need to lookup some info that may fail before we serve the request.
Collaborator
|
CI fail. |
Collaborator
|
It is a breaking change cc @4t145 |
jokemanfire
approved these changes
Jun 14, 2025
Collaborator
|
Ok to me |
loocor
pushed a commit
to loocor/rust-sdk
that referenced
this pull request
Jun 17, 2025
modelcontextprotocol#244) * feat: allow failable service creation in streamable HTTP tower service In our setup we need to lookup some info that may fail before we serve the request. * Fix examples build
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
In our setup we need to lookup some info that may fail before we serve the request.
How Has This Been Tested?
Manually tested
Breaking Changes
Yes, minor change in signature
Types of changes
Checklist
Additional context