Skip to content

Conversation

@Z9RTM
Copy link
Contributor

@Z9RTM Z9RTM commented May 18, 2025

Motivation and Context

This change implements a mechanism to nearly automate the process of displaying generated coverage badge images within the project's README.md.

#49 (comment)

How Has This Been Tested?

just run act pull_request -j coverage

Breaking Changes

no

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • CI

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

run: cargo llvm-cov --all-features
run: cargo llvm-cov --all-features --lcov --output-path lcov.info

- name: Generate coverage badge
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the badge image will finally generate properly if we run this job on the main branch.

@Z9RTM Z9RTM marked this pull request as ready for review May 18, 2025 13:19
@Z9RTM
Copy link
Contributor Author

Z9RTM commented May 18, 2025

#49

@jokemanfire jokemanfire merged commit 4dc0cad into modelcontextprotocol:main May 19, 2025
8 of 9 checks passed
@jokemanfire
Copy link
Collaborator

Could you check it ,it looks like svg not effective, I think the path in readme has some problems.

@Z9RTM Z9RTM deleted the ci/coverage-badge branch May 19, 2025 13:21
@github-actions github-actions bot mentioned this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants