fix(schemar): Use custom settings without packaging settings #180
Conversation
Ignores fields that are not defined in the spec file. Signed-off-by: jokemanfire <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the schemar configuration to allow custom settings without enforcing packaging settings, providing more flexibility in handling fields not defined in the spec file.
- Replaces the use of schemars::r#gen::SchemaSettings::openapi3() with customized default settings
- Explicitly sets several configuration options (e.g., option_nullable, definitions_path, meta_schema) for schema generation
| /// A shortcut for generating a JSON schema for a type. | ||
| pub fn schema_for_type<T: JsonSchema>() -> JsonObject { | ||
| let settings = schemars::r#gen::SchemaSettings::openapi3(); | ||
| let mut settings = schemars::r#gen::SchemaSettings::default(); |
There was a problem hiding this comment.
Consider adding a comment here explaining why the custom settings are used instead of openapi3(), detailing the specific needs addressed by these settings to aid future maintainers.
There was a problem hiding this comment.
there's no need to do.
There was a problem hiding this comment.
This is a better solution. Nice work
|
Feel free to merge it! |
|
@jokemanfire definitely a good change. Could the configurations have worked with OpenAPIv3? I think there will be other issues that arise because we won't have the latest. |
3 participants
The Shemar configuration of the packaging lacks flexibility and ignores fields that are not defined in the spec file.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context