Skip to content

fix(rmcp-macros): fix extract_doc_line code #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2025
Merged

fix(rmcp-macros): fix extract_doc_line code #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions crates/rmcp-macros/src/tool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,33 +296,27 @@ pub(crate) fn tool_impl_item(attr: TokenStream, mut input: ItemImpl) -> syn::Res
})
}

// extract doc line from attribute
fn extract_doc_line(attr: &syn::Attribute) -> Option<String> {
if !attr.path().is_ident("doc") {
return None;
}

let name_value = match &attr.meta {
syn::Meta::NameValue(nv) => nv,
_ => return None,
let syn::Meta::NameValue(name_value) = &attr.meta else {
return None;
};

let expr_lit = match &name_value.value {
syn::Expr::Lit(lit) => lit,
_ => return None,
let syn::Expr::Lit(expr_lit) = &name_value.value else {
return None;
};

let lit_str = match &expr_lit.lit {
syn::Lit::Str(s) => s,
_ => return None,
let syn::Lit::Str(lit_str) = &expr_lit.lit else {
return None;
};

let content = lit_str.value().trim().to_string();

if content.is_empty() {
None
} else {
Some(content)
}
(!content.is_empty()).then_some(content)
}

pub(crate) fn tool_fn_item(attr: TokenStream, mut input_fn: ItemFn) -> syn::Result<TokenStream> {
Expand Down
Loading