Skip to content

Update hidi transform command to include the endpoint version #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2023
Merged

Update hidi transform command to include the endpoint version #985

merged 1 commit into from
Mar 30, 2023

Conversation

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Mar 29, 2023 •
edited
Loading

Summary

Update OpenAPI generation script by adding the metadata version as a command-line argument during conversion

Command line arguments to run these changes

hidi transform --csdl ""$inputFile"" --output ""$outputFile"" --settings-path ""$settings"" --version OpenApi3_0 --metadata-version ""$endpointVersion"" --log-level Information --format yaml
Microsoft Reviewers: Open in CodeFlow

@MaggieKimani1
Update generate-open-api.ps1
b72fe2f 
Update script by adding a metadata version parameter for conversion
@MaggieKimani1
Copy link
Contributor Author

MaggieKimani1 commented Mar 29, 2023

This PR is on hold till we deploy Hidi with this enhancement - microsoft/OpenAPI.NET#1197

@baywet baywet merged commit 3afffc1 into microsoftgraph:dev Mar 30, 2023
@irvinesunday irvinesunday mentioned this pull request Apr 3, 2023
Closed
@baywet baywet mentioned this pull request Apr 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddyett ddyett Awaiting requested review from ddyett

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@nikithauc nikithauc Awaiting requested review from nikithauc

@zengin zengin Awaiting requested review from zengin

@ramsessanchez ramsessanchez Awaiting requested review from ramsessanchez

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

@SilasKenneth SilasKenneth Awaiting requested review from SilasKenneth

@rkodev rkodev Awaiting requested review from rkodev

2 more reviewers

@andrueastman andrueastman andrueastman approved these changes

@baywet baywet baywet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaggieKimani1 @andrueastman @baywet