From 6eb5b8893c87447ba95b1dd9b923251d35cc2a46 Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Tue, 1 Aug 2023 14:43:22 -0700 Subject: [PATCH 1/2] try removing smoke test requirement --- build/smoke-test-requirements.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/build/smoke-test-requirements.txt b/build/smoke-test-requirements.txt index 7d5ac3da00d9..154c84ba926e 100644 --- a/build/smoke-test-requirements.txt +++ b/build/smoke-test-requirements.txt @@ -1,6 +1,6 @@ # List of requirements for smoke tests (they will attempt to run a kernel) -jupyter -numpy -matplotlib -pandas -livelossplot \ No newline at end of file +# jupyter +# numpy +# matplotlib +# pandas +# livelossplot From a808d963fac0a0938db48ab83d213a2e1c971655 Mon Sep 17 00:00:00 2001 From: Anthony Kim Date: Wed, 2 Aug 2023 11:28:50 -0700 Subject: [PATCH 2/2] remove stale references to smoke-test-requirements.txt --- .github/actions/smoke-tests/action.yml | 6 ------ build/smoke-test-requirements.txt | 6 ------ scripts/onCreateCommand.sh | 1 - 3 files changed, 13 deletions(-) delete mode 100644 build/smoke-test-requirements.txt diff --git a/.github/actions/smoke-tests/action.yml b/.github/actions/smoke-tests/action.yml index 9ad6e87cdd26..b2d002050433 100644 --- a/.github/actions/smoke-tests/action.yml +++ b/.github/actions/smoke-tests/action.yml @@ -26,7 +26,6 @@ runs: cache-dependency-path: | build/test-requirements.txt requirements.txt - build/smoke-test-requirements.txt - name: Install dependencies (npm ci) run: npm ci --prefer-offline @@ -43,11 +42,6 @@ runs: python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --implementation py --no-deps --upgrade --pre debugpy shell: bash - - name: pip install smoke test requirements - run: | - python -m pip install --upgrade -r build/smoke-test-requirements.txt - shell: bash - # Bits from the VSIX are reused by smokeTest.ts to speed things up. - name: Download VSIX uses: actions/download-artifact@v2 diff --git a/build/smoke-test-requirements.txt b/build/smoke-test-requirements.txt deleted file mode 100644 index 154c84ba926e..000000000000 --- a/build/smoke-test-requirements.txt +++ /dev/null @@ -1,6 +0,0 @@ -# List of requirements for smoke tests (they will attempt to run a kernel) -# jupyter -# numpy -# matplotlib -# pandas -# livelossplot diff --git a/scripts/onCreateCommand.sh b/scripts/onCreateCommand.sh index e93c74f610b9..a90a5366417d 100644 --- a/scripts/onCreateCommand.sh +++ b/scripts/onCreateCommand.sh @@ -29,7 +29,6 @@ source /workspaces/vscode-python/.venv/bin/activate npx gulp installPythonLibs /workspaces/vscode-python/.venv/bin/python -m pip install -r build/test-requirements.txt -/workspaces/vscode-python/.venv/bin/python -m pip install -r build/smoke-test-requirements.txt /workspaces/vscode-python/.venv/bin/python -m pip install -r build/functional-test-requirements.txt # Below will crash codespace