Disable run-by-line and continue buttons when actively running by line #12170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
IanMatthewHuff
commented
Jun 5, 2020
|
|
||
| private async handleStep() { | ||
| // User issued a step command. | ||
| this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined }); |
Member
Author
There was a problem hiding this comment.
Maybe a rename on this message? It's just to get our mode back into run mode from design mode. Initially I had something like a .EnterDebugRun message, but it ended up just doing the same thing as ShowContinue.
IanMatthewHuff
requested review from
DavidKutu,
DonJayamanne,
greazer,
joyceerhl,
rchiodo and
techwithtim
joyceerhl
approved these changes
Jun 5, 2020
DavidKutu
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12169
I'm going to have a follow up item to change the ip, but I need an icon for that and doing the state here should make this super easy.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).