Skip to content

Commit c49d6db

Browse files
author
Kartik Raj
committed
Do not localize strings
1 parent dcf51c7 commit c49d6db

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

package.nls.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@
167167
"Common.openOutputPanel": "Show output",
168168
"LanguageService.statusItem.name":"Python IntelliSense Status",
169169
"LanguageService.statusItem.text": "Partial Mode",
170-
"LanguageService.statusItem.detail": "Only limited Intellisense via Pylance is supported.",
170+
"LanguageService.statusItem.detail": "Limited IntelliSense provided by Pylance",
171171
"LanguageService.lsFailedToStart": "We encountered an issue starting the language server. Reverting to Jedi language engine. Check the Python output panel for details.",
172172
"LanguageService.lsFailedToDownload": "We encountered an issue downloading the language server. Reverting to Jedi language engine. Check the Python output panel for details.",
173173
"LanguageService.lsFailedToExtract": "We encountered an issue extracting the language server. Reverting to Jedi language engine. Check the Python output panel for details.",

src/client/browser/intellisenseStatus.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,21 @@
33

44
// IMPORTANT: Do not import any node fs related modules here, as they do not work in browser.
55
import * as vscode from 'vscode';
6-
import { Common, LanguageService } from '../common/utils/localize';
76

87
export function createStatusItem(): vscode.Disposable {
8+
// TODO: Note strings are not localized here yet. Localizing strings here
9+
// require us to use browser based fs APIs provided by VSCode:
10+
// https://github.com/microsoft/vscode-python/issues/17712
911
if ('createLanguageStatusItem' in vscode.languages) {
1012
const statusItem = vscode.languages.createLanguageStatusItem('python.projectStatus', {
1113
language: 'python',
1214
});
13-
statusItem.name = LanguageService.statusItem.name();
15+
statusItem.name = 'Python IntelliSense Status';
1416
statusItem.severity = vscode.LanguageStatusSeverity.Warning;
15-
statusItem.text = LanguageService.statusItem.text();
16-
statusItem.detail = LanguageService.statusItem.detail();
17+
statusItem.text = 'Partial Mode';
18+
statusItem.detail = 'Limited IntelliSense provided by Pylance';
1719
statusItem.command = {
18-
title: Common.learnMore(),
20+
title: 'Learn More',
1921
command: 'vscode.open',
2022
arguments: [vscode.Uri.parse('https://aka.ms/AAdzyh4')],
2123
};

src/client/common/utils/localize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ export namespace LanguageService {
208208
export const statusItem = {
209209
name: localize('LanguageService.statusItem.name', 'Python IntelliSense Status'),
210210
text: localize('LanguageService.statusItem.text', 'Partial Mode'),
211-
detail: localize('LanguageService.statusItem.detail', 'Only limited Intellisense via Pylance is supported.'),
211+
detail: localize('LanguageService.statusItem.detail', 'Limited IntelliSense provided by Pylance'),
212212
};
213213
export const startingMicrosoft = localize(
214214
'LanguageService.startingMicrosoft',

0 commit comments

Comments
 (0)