Ensure installs are checked first.

Author: karthiknadig

src/client/providers/prompts/installFormatterPrompt.ts

@@ -50,23 +50,7 @@ export class InstallFormatterPrompt implements IInstallFormatterPrompt {
 
         let selection: string | undefined;
 
-        if (formatter === 'black' && !black) {
-            this.shownThisSession = true;
-            selection = await showInformationMessage(
-                ToolsExtensions.installBlackFormatterPrompt,
-                'Black',
-                'Autopep8',
-                Common.doNotShowAgain,
-            );
-        } else if (formatter === 'autopep8' && !autopep8) {
-            this.shownThisSession = true;
-            selection = await showInformationMessage(
-                ToolsExtensions.installAutopep8FormatterPrompt,
-                'Black',
-                'Autopep8',
-                Common.doNotShowAgain,
-            );
-        } else if (black || autopep8) {
+        if (black || autopep8) {
             this.shownThisSession = true;
             if (black && autopep8) {
                 selection = await showInformationMessage(
@@ -94,6 +78,22 @@ export class InstallFormatterPrompt implements IInstallFormatterPrompt {
                     selection = 'Autopep8';
                 }
             }
+        } else if (formatter === 'black' && !black) {
+            this.shownThisSession = true;
+            selection = await showInformationMessage(
+                ToolsExtensions.installBlackFormatterPrompt,
+                'Black',
+                'Autopep8',
+                Common.doNotShowAgain,
+            );
+        } else if (formatter === 'autopep8' && !autopep8) {
+            this.shownThisSession = true;
+            selection = await showInformationMessage(
+                ToolsExtensions.installAutopep8FormatterPrompt,
+                'Black',
+                'Autopep8',
+                Common.doNotShowAgain,
+            );
         }
 
         if (selection === 'Black') {

src/client/providers/prompts/promptUtils.ts

@@ -5,7 +5,7 @@ import { ConfigurationTarget, Uri } from 'vscode';
 import { ShowFormatterExtensionPrompt } from '../../common/experiments/groups';
 import { IExperimentService, IPersistentState, IPersistentStateFactory } from '../../common/types';
 import { executeCommand } from '../../common/vscodeApis/commandApis';
-import { isInsider, getExtension } from '../../common/vscodeApis/extensionsApi';
+import { isInsider } from '../../common/vscodeApis/extensionsApi';
 import { getConfiguration, getWorkspaceFolder } from '../../common/vscodeApis/workspaceApis';
 import { IServiceContainer } from '../../ioc/types';
 
@@ -34,11 +34,5 @@ export async function installFormatterExtension(extensionId: string, resource?:
         installPreReleaseVersion: isInsider(),
     });
 
-    const extension = getExtension(extensionId);
-    if (!extension) {
-        return;
-    }
-
-    await extension.activate();
     await updateDefaultFormatter(extensionId, resource);
 }