inferredTypeFromTransitiveModule tests

Author: sheetalkamat

internal/checker/checker.go

@@ -30272,7 +30272,7 @@ func (c *Checker) getSymbolAtLocation(node *ast.Node, ignoreErrors bool) *ast.Sy
 		// 4). type A = import("./f/*gotToDefinitionHere*/oo")
 		if (ast.IsExternalModuleImportEqualsDeclaration(grandParent) && ast.GetExternalModuleImportEqualsDeclarationExpression(grandParent) == node) ||
 			((parent.Kind == ast.KindImportDeclaration || parent.Kind == ast.KindJSImportDeclaration || parent.Kind == ast.KindExportDeclaration) && ast.GetExternalModuleName(parent) == node) ||
-			ast.IsVariableDeclarationInitializedToRequire(grandParent) ||
+			ast.IsVariableDeclarationInitializedToRequire(grandParent) || ast.IsImportCall(parent) ||
 			(ast.IsLiteralTypeNode(parent) && ast.IsLiteralImportTypeNode(grandParent) && grandParent.AsImportTypeNode().Argument == parent) {
 			return c.resolveExternalModuleName(node, node, ignoreErrors)
 		}

internal/execute/tscbuild_test.go

@@ -390,6 +390,88 @@ func TestBuildFileDelete(t *testing.T) {
 	}
 }
 
+func TestBuildInferredTypeFromTransitiveModule(t *testing.T) {
+	t.Parallel()
+	testCases := []*tscInput{
+		{
+			subScenario:     "inferred type from transitive module",
+			files:           getBuildInferredTypeFromTransitiveModuleMap(false, ""),
+			commandLineArgs: []string{"--b", "--verbose"},
+			edits: []*tscEdit{
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "param: string", "")
+					},
+				},
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "foobar()", "foobar(param: string)")
+					},
+				},
+			},
+		},
+		{
+			subScenario:     "inferred type from transitive module with isolatedModules",
+			files:           getBuildInferredTypeFromTransitiveModuleMap(true, ""),
+			commandLineArgs: []string{"--b", "--verbose"},
+			edits: []*tscEdit{
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "param: string", "")
+					},
+				},
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "foobar()", "foobar(param: string)")
+					},
+				},
+			},
+		},
+		{
+			subScenario: "reports errors in files affected by change in signature with isolatedModules",
+			files: getBuildInferredTypeFromTransitiveModuleMap(true, stringtestutil.Dedent(`
+				import { default as bar } from './bar';
+				bar("hello");
+			`)),
+			commandLineArgs: []string{"--b", "--verbose"},
+			edits: []*tscEdit{
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "param: string", "")
+					},
+				},
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "foobar()", "foobar(param: string)")
+					},
+				},
+				{
+					caption: "incremental-declaration-changes",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/bar.ts", "param: string", "")
+					},
+				},
+				{
+					caption: "Fix Error",
+					edit: func(sys *testSys) {
+						sys.replaceFileText("/home/src/workspaces/project/lazyIndex.ts", `bar("hello")`, "bar()")
+					},
+				},
+			},
+		},
+	}
+
+	for _, test := range testCases {
+		test.run(t, "inferredTypeFromTransitiveModule")
+	}
+}
+
 func TestBuildSolutionProject(t *testing.T) {
 	t.Parallel()
 	testCases := []*tscInput{
@@ -756,3 +838,60 @@ func getBuildEmitDeclarationOnlyTestCase(declarationMap bool) *tscInput {
 		},
 	}
 }
+
+func getBuildInferredTypeFromTransitiveModuleMap(isolatedModules bool, lazyExtraContents string) FileMap {
+	return FileMap{
+		"/home/src/workspaces/project/bar.ts": stringtestutil.Dedent(`
+			interface RawAction {
+				(...args: any[]): Promise<any> | void;
+			}
+			interface ActionFactory {
+				<T extends RawAction>(target: T): T;
+			}
+			declare function foo<U extends any[] = any[]>(): ActionFactory;
+			export default foo()(function foobar(param: string): void {
+			});
+		`),
+		"/home/src/workspaces/project/bundling.ts": stringtestutil.Dedent(`
+			export class LazyModule<TModule> {
+				constructor(private importCallback: () => Promise<TModule>) {}
+			}
+
+			export class LazyAction<
+				TAction extends (...args: any[]) => any,
+				TModule
+			>  {
+				constructor(_lazyModule: LazyModule<TModule>, _getter: (module: TModule) => TAction) {
+				}
+			}
+		`),
+		"/home/src/workspaces/project/global.d.ts": stringtestutil.Dedent(`
+			interface PromiseConstructor {
+				new <T>(): Promise<T>;
+			}
+			declare var Promise: PromiseConstructor;
+			interface Promise<T> {
+			}
+		`),
+		"/home/src/workspaces/project/index.ts": stringtestutil.Dedent(`
+			import { LazyAction, LazyModule } from './bundling';
+			const lazyModule = new LazyModule(() =>
+				import('./lazyIndex')
+			);
+			export const lazyBar = new LazyAction(lazyModule, m => m.bar);
+		`),
+		"/home/src/workspaces/project/lazyIndex.ts": stringtestutil.Dedent(`
+			export { default as bar } from './bar';
+		`) + lazyExtraContents,
+		"/home/src/workspaces/project/tsconfig.json": stringtestutil.Dedent(fmt.Sprintf(`
+			{
+                "compilerOptions": {
+                    "target": "es5",
+                    "declaration": true,
+                    "outDir": "obj",
+                    "incremental": true,
+					"isolatedModules": %t,
+                },
+            }`, isolatedModules)),
+	}
+}

testdata/baselines/reference/fourslash/goToDef/GoToDefinitionDynamicImport1.baseline.jsonc

@@ -1,16 +1,16 @@
 // === goToDefinition ===
 // === /foo.ts ===
 
-// export function foo() { return "foo"; }
+// [|export function foo() { return "foo"; }
 // import("./f/*GO TO DEFINITION*/oo")
-// var x = import("./foo")
+// var x = import("./foo")|]
 
 
 
 
 // === goToDefinition ===
 // === /foo.ts ===
 
-// export function foo() { return "foo"; }
+// [|export function foo() { return "foo"; }
 // import("./foo")
-// var x = import("./fo/*GO TO DEFINITION*/o")
+// var x = import("./fo/*GO TO DEFINITION*/o")|]

testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.symbols

@@ -8,6 +8,7 @@ export function a() {}
 export const x = add(import("./sub"));
 >x : Symbol(x, Decl(index.ts, 0, 12))
 >add : Symbol(add, Decl(index.ts, 1, 27))
+>"./sub" : Symbol("sub", Decl(sub.ts, 0, 0))
 
 export * as Q from "./sub";
 >Q : Symbol(Q, Decl(index.ts, 1, 6))

testdata/baselines/reference/submodule/compiler/declarationEmitDoesNotUseReexportedNamespaceAsLocal.symbols.diff

@@ -28,6 +28,7 @@ export default (suit: Suit, rank: Rank) => ({suit, rank});
 export let lazyCard = () => import('./Card').then(a => a.default);
 >lazyCard : Symbol(lazyCard, Decl(index.ts, 0, 10))
 >import('./Card').then : Symbol(then, Decl(lib.es5.d.ts, --, --))
+>'./Card' : Symbol("Card", Decl(Card.ts, 0, 0))
 >then : Symbol(then, Decl(lib.es5.d.ts, --, --))
 >a : Symbol(a, Decl(index.ts, 0, 50))
 >a.default : Symbol(default, Decl(Card.ts, 0, 37))

testdata/baselines/reference/submodule/compiler/declarationEmitExportAliasVisibiilityMarking.symbols

@@ -5,9 +5,9 @@
  export let lazyCard = () => import('./Card').then(a => a.default);
  >lazyCard : Symbol(lazyCard, Decl(index.ts, 0, 10))
 ->import('./Card').then : Symbol(Promise.then, Decl(lib.es5.d.ts, --, --))
-->'./Card' : Symbol("Card", Decl(Card.ts, 0, 0))
-->then : Symbol(Promise.then, Decl(lib.es5.d.ts, --, --))
 +>import('./Card').then : Symbol(then, Decl(lib.es5.d.ts, --, --))
+ >'./Card' : Symbol("Card", Decl(Card.ts, 0, 0))
+->then : Symbol(Promise.then, Decl(lib.es5.d.ts, --, --))
 +>then : Symbol(then, Decl(lib.es5.d.ts, --, --))
  >a : Symbol(a, Decl(index.ts, 0, 50))
  >a.default : Symbol(default, Decl(Card.ts, 0, 37))

testdata/baselines/reference/submodule/compiler/declarationEmitExportAliasVisibiilityMarking.symbols.diff

@@ -24,9 +24,14 @@ export const mod = await (async () => {
 
     case 0:
       return await import("./case0.js");
+>"./case0.js" : Symbol("/case0", Decl(case0.ts, 0, 0))
+
     case 1:
       return await import("./case1.js");
+>"./case1.js" : Symbol("/case1", Decl(case1.ts, 0, 0))
+
     default:
       return await import("./caseFallback.js");
+>"./caseFallback.js" : Symbol("/caseFallback", Decl(caseFallback.ts, 0, 0))
   }
 })();

testdata/baselines/reference/submodule/compiler/dynamicImportsDeclaration.symbols

@@ -8,4 +8,5 @@ export = x;
 >x : Symbol(x, Decl(a.ts, 0, 10))
 
 import("./a");
+>"./a" : Symbol("/a", Decl(a.ts, 0, 0))