Fix incorrect passing of compile times (#1626)

Author: sheetalkamat

internal/execute/build/buildtask.go

@@ -122,7 +122,7 @@ func (t *buildTask) buildProject(orchestrator *Orchestrator, path tspath.Path) {
 			t.reportDiagnostic,
 			tsc.QuietDiagnosticsReporter,
 			&t.builder,
-			compileTimes,
+			&compileTimes,
 			orchestrator.opts.Testing,
 		)
 		t.exitStatus = result.Status

internal/execute/tsc.go

@@ -222,7 +222,7 @@ func tscCompilation(sys tsc.System, commandLine *tsoptions.ParsedCommandLine, te
 			reportDiagnostic,
 			reportErrorSummary,
 			extendedConfigCache,
-			compileTimes,
+			&compileTimes,
 			testing,
 		)
 	}
@@ -232,7 +232,7 @@ func tscCompilation(sys tsc.System, commandLine *tsoptions.ParsedCommandLine, te
 		reportDiagnostic,
 		reportErrorSummary,
 		extendedConfigCache,
-		compileTimes,
+		&compileTimes,
 		testing,
 	)
 }
@@ -261,7 +261,7 @@ func performIncrementalCompilation(
 	reportDiagnostic tsc.DiagnosticReporter,
 	reportErrorSummary tsc.DiagnosticsReporter,
 	extendedConfigCache tsoptions.ExtendedConfigCache,
-	compileTimes tsc.CompileTimes,
+	compileTimes *tsc.CompileTimes,
 	testing tsc.CommandLineTesting,
 ) tsc.CommandLineResult {
 	host := compiler.NewCachedFSCompilerHost(sys.GetCurrentDirectory(), sys.FS(), sys.DefaultLibraryPath(), extendedConfigCache, getTraceFromSys(sys, testing))
@@ -304,7 +304,7 @@ func performCompilation(
 	reportDiagnostic tsc.DiagnosticReporter,
 	reportErrorSummary tsc.DiagnosticsReporter,
 	extendedConfigCache tsoptions.ExtendedConfigCache,
-	compileTimes tsc.CompileTimes,
+	compileTimes *tsc.CompileTimes,
 	testing tsc.CommandLineTesting,
 ) tsc.CommandLineResult {
 	host := compiler.NewCachedFSCompilerHost(sys.GetCurrentDirectory(), sys.FS(), sys.DefaultLibraryPath(), extendedConfigCache, getTraceFromSys(sys, testing))

internal/execute/tsc/compile.go

@@ -71,5 +71,5 @@ type CompileAndEmitResult struct {
 	Diagnostics []*ast.Diagnostic
 	EmitResult  *compiler.EmitResult
 	Status      ExitStatus
-	times       CompileTimes
+	times       *CompileTimes
 }

internal/execute/tsc/emit.go

@@ -30,7 +30,7 @@ func EmitAndReportStatistics(
 	reportDiagnostic DiagnosticReporter,
 	reportErrorSummary DiagnosticsReporter,
 	w io.Writer,
-	compileTimes CompileTimes,
+	compileTimes *CompileTimes,
 	testing CommandLineTesting,
 ) (CompileAndEmitResult, *Statistics) {
 	var statistics *Statistics
@@ -48,7 +48,7 @@ func EmitAndReportStatistics(
 		runtime.GC()
 		runtime.ReadMemStats(&memStats)
 
-		statistics = statisticsFromProgram(program, &compileTimes, &memStats)
+		statistics = statisticsFromProgram(program, compileTimes, &memStats)
 		statistics.Report(w, testing)
 	}
 
@@ -67,7 +67,7 @@ func EmitFilesAndReportErrors(
 	reportDiagnostic DiagnosticReporter,
 	reportErrorSummary DiagnosticsReporter,
 	w io.Writer,
-	compileTimes CompileTimes,
+	compileTimes *CompileTimes,
 	testing CommandLineTesting,
 ) (result CompileAndEmitResult) {
 	result.times = compileTimes

internal/execute/watcher.go

@@ -94,7 +94,7 @@ func (w *Watcher) DoCycle() {
 func (w *Watcher) compileAndEmit() {
 	// !!! output/error reporting is currently the same as non-watch mode
 	// diagnostics, emitResult, exitStatus :=
-	tsc.EmitFilesAndReportErrors(w.sys, w.program, w.program.GetProgram(), w.reportDiagnostic, w.reportErrorSummary, w.sys.Writer(), tsc.CompileTimes{}, w.testing)
+	tsc.EmitFilesAndReportErrors(w.sys, w.program, w.program.GetProgram(), w.reportDiagnostic, w.reportErrorSummary, w.sys.Writer(), &tsc.CompileTimes{}, w.testing)
 }
 
 func (w *Watcher) hasErrorsInTsConfig() bool {