This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Ship-room: Added libomp instructions.
#901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
commented
Jan 14, 2022
| * Install [.NET Core 3 SDK](https://dotnet.microsoft.com/download) | ||
| * On [WSL](https://docs.microsoft.com/en-us/windows/wsl/)/Linux: | ||
| * Install `g++` (e.g. in Ubuntu 20.04 `sudo apt-get install g++`). | ||
| * Install [`libomp`](https://openmp.llvm.org) needed for the native (C++) full-state simulator. |
Contributor
Author
There was a problem hiding this comment.
For other platforms the libomp is installed automatically:
Mac: src\Simulation\Native\prerequisites.ps1
Win: As part of MSVC/Clang.
Contributor
There was a problem hiding this comment.
To clarify, this is only the build instructions, right? If I understand correctly, since libomp is included in the NuGet package, we should have no user-facing dependencies at all.
cgranade
approved these changes
Jan 14, 2022
| * Install [.NET Core 3 SDK](https://dotnet.microsoft.com/download) | ||
| * On [WSL](https://docs.microsoft.com/en-us/windows/wsl/)/Linux: | ||
| * Install `g++` (e.g. in Ubuntu 20.04 `sudo apt-get install g++`). | ||
| * Install [`libomp`](https://openmp.llvm.org) needed for the native (C++) full-state simulator. |
Contributor
There was a problem hiding this comment.
To clarify, this is only the build instructions, right? If I understand correctly, since libomp is included in the NuGet package, we should have no user-facing dependencies at all.
kuzminrobin
force-pushed
the
kuzminrobin/libOMPinstructions
branch
from
62c8275 to
f767b6e
Compare
kuzminrobin
force-pushed
the
kuzminrobin/libOMPinstructions
branch
from
f767b6e to
7f328dc
Compare
vxfield
added a commit
that referenced
this pull request
Jan 21, 2022
* Update .NET Azure Quantum SDK version * Temporarily adjusting broken links * Update xfield/update-net-sdk (#907) * Fix capitalization in xref links (#902) xref links in https://docs.microsoft.com/en-us/qsharp/api/qsharp/microsoft.quantum.diagnostics.assertqubitwithintolerance and https://docs.microsoft.com/en-us/qsharp/api/qsharp/microsoft.quantum.diagnostics.assertqubit don't render as links. I believe docgen doesn't recognize API links if they are given in lowercase, it needs proper capitalization in xref. Co-authored-by: XField <[email protected]> * Update macOS build scripts for libomp dependency (#906) * Link against checked in libomp.dylib * Try another explicit link strategy * Show contents of osx folder * Try another linker strategy * go back to old linker pattern * try other syntax * Try checked in openmp headers * try getting more info from otool * Try adapting libomp rpath on mac * Ensure libomp lands in drops folder * Additional copy of libomp * Add explanatory comments * Use @loader_path instead of @executable_path Co-authored-by: Mariia Mykhailova <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> * Added `libomp` instructions. (#901) Co-authored-by: Mariia Mykhailova <[email protected]> Co-authored-by: Stefan J. Wernli <[email protected]> Co-authored-by: Robin Kuzmin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.