This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Migrate native simulator from GCC to Clang. #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzminrobin
force-pushed
the
kuzminrobin/gcc-version-fix3
branch
from
d21860a to
8876e69
Compare
kuzminrobin
force-pushed
the
kuzminrobin/gcc-version-fix3
branch
2 times, most recently
from
be622c1 to
c915708
Compare
kuzminrobin
force-pushed
the
kuzminrobin/gcc-version-fix3
branch
from
c915708 to
3126e99
Compare
kuzminrobin
force-pushed
the
kuzminrobin/gcc-version-fix3
branch
from
aaa16f4 to
c48ca6c
Compare
…m.Simulation.Simulators.Tests/QuantumSimulatorTests/ZeroStateQubitReleaseTest`. Likely Clang-11 issue (on Win and Linux) as opposed to AppleClang 13.0.0.13000029 (on Mac). Consider migrating to Clang-13 and reverting this change.
kuzminrobin
changed the title
kuzminrobin
requested review from
DmitryVasilevsky,
bettinaheim,
cgranade,
idavis and
swernli
swernli
reviewed
Dec 3, 2021
Collaborator
swernli
left a comment
swernli
left a comment
There was a problem hiding this comment.
One minor point of feedback, so I'm not approving yet to avoid triggering the auto-merge.
swernli
approved these changes
Dec 3, 2021
Contributor
|
@kuzminrobin Please take a look at the performance tests to double check that the change didn't have any negative performance impact. |
kuzminrobin
added a commit
that referenced
this pull request
Dec 6, 2021
kuzminrobin
added a commit
that referenced
this pull request
Dec 6, 2021
kuzminrobin
added a commit
that referenced
this pull request
Dec 6, 2021
kuzminrobin
added a commit
that referenced
this pull request
Jan 5, 2022
* Re-trying the PR #881. * Added copying libomp on Mac and Linux. * Fixed the omp lib for Win.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #876.
This PR started as upgrading the GCC and ended up in migrating from GCC to Clang.