Skip to content
This repository was archived by the owner on Jan 12, 2024. It is now read-only.

Conversation

@vxfield
Copy link
Member

@vxfield vxfield commented Oct 15, 2021

This PR introduces a common Telemetry Library (.NET class library) to be used by the Quantum Development Kit.

This library provides a single place where we can put all of our core telemetry logic, reducing code duplication across multiple QDK products and bringing the following benefits:

  1. Makes it easier to comply to telemetry, data collection and privacy policies in a standard/consistent way, such as opt-in and opt-out controls
  2. Comprehensive unit test (and, in the future, integration test) coverage
  3. Ability to share common event properties and schemas across different QDK products
  4. Makes it easier for QDK developers to add instrumentation to the products (with included C# and F# samples)
  5. Support for out-of-process telemetry upload, to reduce the run time of short-lived console applications

@vxfield

This comment has been minimized.

@vxfield vxfield requested a review from cgranade October 15, 2021 15:43
@vxfield

This comment has been minimized.

@vxfield vxfield requested a review from bamarsha October 18, 2021 03:36
@vxfield

This comment has been minimized.

@bamarsha

This comment has been minimized.

@vxfield

This comment has been minimized.

@vxfield vxfield changed the title [DRAFT] Quantum Development Kit Telemetry Library Quantum Development Kit Telemetry Library Nov 6, 2021
anpaz
anpaz previously requested changes Nov 6, 2021
Copy link
Member

@anpaz anpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, but I do have several things that should be revised.

@vxfield vxfield requested a review from anpaz November 9, 2021 16:56
@vxfield vxfield enabled auto-merge (squash) November 9, 2021 20:21
@vxfield vxfield dismissed anpaz’s stale review November 10, 2021 01:32

For some reason GitHub is not letting me resolve one conversation and it's blocking the PR. Since I addressed all the feedback, I'll go ahead and merge the PR.

@vxfield vxfield merged commit 2555a55 into main Nov 10, 2021
@vxfield vxfield deleted the xfield/telemetry branch November 10, 2021 03:58
cesarzc added a commit that referenced this pull request Nov 16, 2021
* added MSBuild_Logs to gitignore (#1171)

* Command Line Support for Project File Input (#1192)

* Change --inputs to --input (#1210)

* Deprecate new array expression (#956)

* Removing temporary project (#1225)

* Formatter Updates Deprecated Boolean Operator Syntax (#1214)

* Update the documentation found in the Q# Formatter Project (#1203)

* Formatter Updates Deprecated Specialization Declaration Parameters (#1226)

* Adding Sdk integration, and formatting support + code action for syntax updates to the language server (#1207)

* QAT v. 0.1 (#1230)

* Sdk changes to support Qir targets (#1238)

* Quantum Development Kit Telemetry Library (#1199)

Co-authored-by: Sarah Marshall <[email protected]>
Co-authored-by: Scott Carda <[email protected]>

* Allowing to use the LLVM intrinsic readcyclecounter from Q# (#1248)

* Do case-insensitive comparisons for targets names (#1241)

During the build stage of a Q# job submission via the CLI or the stand-alone executable, there is a case sensitive enforcement of target names.

Since this limitation does not exist in the service or in other clients, we're aligning by making the corresponding comparison case insensitive.

* Refactor language server code for extracting symbols from Q# fragments (#1220)

* Start adding SymbolOccurrence module

* Replace SymbolInformation implementation

* Add C# interop for SymbolOccurrence

* Rename SymbolInformation.cs to match class name

* Mark SymbolInformation as obsolete

* Add SymbolOccurrence.fsi

* Add doc comments

* Fix nullable errors with .NET Core 3.1

* Use as instead of is

* Take in fragment instead of file in SymbolOccurrence

* Update todo comments

* Return NS in open directive as UsedVariable

* Use TryGet for SymbolOccurrence C# API

* Statement Kinds Support (#1212)

* Addressing last comments - QAT v0.1 (#1240)

* Type renaming

* Removing redudant setModulePassManager

* Fixing recursion

* Refactoring filenames

* Renaming directory

* Updating names and files

* Formatting

* Fixing include

* Updates for QIR validation (#1250)

* Type renaming

* Removing redudant setModulePassManager

* Fixing recursion

* Refactoring filenames

* Renaming directory

* Updating names and files

* Formatting

* Changing default to interop friendly

* Updating base profile

* Styling

* Updating logger

* Fixing style

* Removing comment

* Moving testing to run before linting

* Updating CMake

* Attempting to solve tests issue

* Updating according to PR comments

* Complete NamespaceItem in qsfmt (#1239)

Co-authored-by: Filip W <[email protected]>
Co-authored-by: Scott Carda <[email protected]>
Co-authored-by: Sarah Marshall <[email protected]>
Co-authored-by: bettinaheim <[email protected]>
Co-authored-by: Jintao YU <[email protected]>
Co-authored-by: Troels F. Rønnow <[email protected]>
Co-authored-by: XField <[email protected]>
Co-authored-by: Ricardo Espinoza <[email protected]>
ryan-moreno pushed a commit that referenced this pull request Nov 22, 2021
Co-authored-by: Sarah Marshall <[email protected]>
Co-authored-by: Scott Carda <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants