From ae8b7ce0ecdcdfe80c69a2ebaba143ebaee96ec1 Mon Sep 17 00:00:00 2001
From: Gustavo Hidalgo <guhidalgo@microsoft.com>
Date: Fri, 12 Apr 2024 10:21:19 -0400
Subject: [PATCH 1/3] Add AKS cluster maintenance window.

---
 deployment/terraform/resources/aks.tf | 29 +++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/deployment/terraform/resources/aks.tf b/deployment/terraform/resources/aks.tf
index cb720b20..6dd42d99 100644
--- a/deployment/terraform/resources/aks.tf
+++ b/deployment/terraform/resources/aks.tf
@@ -38,6 +38,35 @@ resource "azurerm_kubernetes_cluster" "pc" {
     azure_rbac_enabled = true
   }
 
+  maintenance_window {
+    allowed {
+      day = "Saturday"
+      hours = [10, 11, 12, 13, 14, 15, 16, 17, 18]
+    }
+    # not_allowed {
+    #   start = ISO8601
+    #   end = ISO8601
+    # }
+  }
+
+  # Recommendation is to make it at least 4 hours long
+  # https://learn.microsoft.com/en-us/azure/aks/planned-maintenance?tabs=json-file#creating-a-maintenance-window
+  maintenance_window_auto_upgrade {
+    frequency = "Weekly"
+    interval = 1
+    duration = 4
+    utc_offset = 0
+    start_time = "10:00" # UTC
+  }
+
+  maintenance_window_node_os {
+    frequency = "Weekly"
+    interval = 1
+    duration = 4
+    utc_offset = 0
+    start_time = "14:00" # UTC
+  }
+
   tags = {
     Environment = var.environment
     ManagedBy   = "AI4E"

From 3f2090c4804365b9722dcd6540f7e6b9cec653e9 Mon Sep 17 00:00:00 2001
From: Gustavo Hidalgo <guhidalgo@microsoft.com>
Date: Fri, 12 Apr 2024 10:33:41 -0400
Subject: [PATCH 2/3] Add day of week

---
 deployment/terraform/resources/aks.tf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/deployment/terraform/resources/aks.tf b/deployment/terraform/resources/aks.tf
index 6dd42d99..0668d185 100644
--- a/deployment/terraform/resources/aks.tf
+++ b/deployment/terraform/resources/aks.tf
@@ -53,6 +53,7 @@ resource "azurerm_kubernetes_cluster" "pc" {
   # https://learn.microsoft.com/en-us/azure/aks/planned-maintenance?tabs=json-file#creating-a-maintenance-window
   maintenance_window_auto_upgrade {
     frequency = "Weekly"
+    day_of_week = "Saturday"
     interval = 1
     duration = 4
     utc_offset = 0
@@ -61,6 +62,7 @@ resource "azurerm_kubernetes_cluster" "pc" {
 
   maintenance_window_node_os {
     frequency = "Weekly"
+    day_of_week = "Saturday"
     interval = 1
     duration = 4
     utc_offset = 0

From 8c1ab4fbc9076b2b079ca63676a32efb04d73006 Mon Sep 17 00:00:00 2001
From: Gustavo Hidalgo <guhidalgo@microsoft.com>
Date: Fri, 12 Apr 2024 10:35:16 -0400
Subject: [PATCH 3/3] fix utc_offset

---
 deployment/terraform/resources/aks.tf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/deployment/terraform/resources/aks.tf b/deployment/terraform/resources/aks.tf
index 0668d185..23452424 100644
--- a/deployment/terraform/resources/aks.tf
+++ b/deployment/terraform/resources/aks.tf
@@ -56,7 +56,7 @@ resource "azurerm_kubernetes_cluster" "pc" {
     day_of_week = "Saturday"
     interval = 1
     duration = 4
-    utc_offset = 0
+    utc_offset = "+00:00"
     start_time = "10:00" # UTC
   }
 
@@ -65,7 +65,7 @@ resource "azurerm_kubernetes_cluster" "pc" {
     day_of_week = "Saturday"
     interval = 1
     duration = 4
-    utc_offset = 0
+    utc_offset = "+00:00"
     start_time = "14:00" # UTC
   }