diff --git a/libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py b/libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py index 841a41f0e..04725db13 100644 --- a/libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py +++ b/libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py @@ -412,7 +412,6 @@ async def on_teams_members_removed_dispatch( # pylint: disable=unused-argument ): teams_members_removed = [] for member in members_removed: - # TODO: fix this new_account_json = member.serialize() if "additional_properties" in new_account_json: del new_account_json["additional_properties"] diff --git a/libraries/botbuilder-core/botbuilder/core/teams/teams_helper.py b/libraries/botbuilder-core/botbuilder/core/teams/teams_helper.py index 4fd3c8ed4..f9d294c39 100644 --- a/libraries/botbuilder-core/botbuilder/core/teams/teams_helper.py +++ b/libraries/botbuilder-core/botbuilder/core/teams/teams_helper.py @@ -10,6 +10,9 @@ import botbuilder.schema as schema import botbuilder.schema.teams as teams_schema +# Optimization: The dependencies dictionary could be cached here, +# and shared between the two methods. + def deserializer_helper(msrest_cls: Type[Model], dict_to_deserialize: dict) -> Model: dependencies = [ @@ -27,9 +30,6 @@ def deserializer_helper(msrest_cls: Type[Model], dict_to_deserialize: dict) -> M return deserializer(msrest_cls.__name__, dict_to_deserialize) -# TODO consolidate these two methods - - def serializer_helper(object_to_serialize: Model) -> dict: if object_to_serialize is None: return None