Fixed type hint in turn_context.py #2147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous type hint implied that send_activity will always return ResourceResponse, meanwhile it can also return None
tracyboehrer
approved these changes
Aug 21, 2024
Contributor
Author
|
"BotBuilder-Python-CI-PR-yaml" step seems to be waiting for something. Do you know what that step is about @tracyboehrer ? I can't seem to find its definition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous type hint implied that send_activity in turn_context.py will always return ResourceResponse, meanwhile it can also return None
Fixes #2146
Description
The type hint is fixed to include possible None return, otherwise it might make the developers assume that there is no need to check for None.
Specific Changes